From commits-return-87918-archive-asf-public=cust-asf.ponee.io@beam.apache.org Mon Aug 13 10:55:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 7E31D180629 for ; Mon, 13 Aug 2018 10:55:06 +0200 (CEST) Received: (qmail 9806 invoked by uid 500); 13 Aug 2018 08:55:05 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 9796 invoked by uid 99); 13 Aug 2018 08:55:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 13 Aug 2018 08:55:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 3ED7AC0090 for ; Mon, 13 Aug 2018 08:55:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id caIE20BT1rOe for ; Mon, 13 Aug 2018 08:55:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CF4CD5F523 for ; Mon, 13 Aug 2018 08:55:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7D763E015E for ; Mon, 13 Aug 2018 08:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 05F6D23F9C for ; Mon, 13 Aug 2018 08:55:01 +0000 (UTC) Date: Mon, 13 Aug 2018 08:55:01 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5063) Watermark does not progress for low traffic streams MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5063?focusedWorklogId=3D1= 34102&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-134102 ] ASF GitHub Bot logged work on BEAM-5063: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Aug/18 08:54 Start Date: 13/Aug/18 08:54 Worklog Time Spent: 10m=20 Work Description: krzysztof-tr opened a new pull request #6178: [BEAM= -5063] Fix Watermark does not progress for low traffic streams URL: https://github.com/apache/beam/pull/6178 =20 =20 Kinesis watermark was extracted to separate class (`KinesisWatermark`) t= o encapsulate its logic. Watermark calculation was changed to mitigate the = problem with too low traffic on the corresponding stream. In new implementa= tion, when watermark was not updated within some period of time, it's updat= ed to the recent min from the `MovingFunction`, regardless of the number of= samples. =20 @pawel-kaczmarczyk, @rtshadow, @kennknowles could you please take a look= at the changes? =20 ------------------------ =20 Follow this checklist to help us incorporate your contribution quickly a= nd easily: =20 - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in Appro= ximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA is= sue, if applicable. This will automatically link the pull request to the is= sue. - [ ] If this contribution is large, please file an Apache [Individual = Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). =20 It will help us expedite review of your Pull Request if you tag someone = (e.g. `@username`) to look at it. =20 Post-Commit Tests Status (on master branch) ------------------------------------------------------------------------= ------------------------ =20 Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_G= radleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/be= am_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- |= --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Ja= va_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/jo= b/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](= https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gra= dle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_Post= Commit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Sta= tus](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dat= aflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/= beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) |= [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_Valida= tesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apach= e.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBu= ild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java= _ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://bu= ilds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/la= stCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_Po= stCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](= https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gr= adle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/= beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/= icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_S= park_Gradle/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_= Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job= /beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status= ](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastComplete= dBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dat= aflow/lastCompletedBuild/)
[![Build Status](https://builds.apache.org= /job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://bui= lds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | = --- | --- | --- =20 =20 =20 =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 134102) Time Spent: 2h 10m (was: 2h) > Watermark does not progress for low traffic streams > --------------------------------------------------- > > Key: BEAM-5063 > URL: https://issues.apache.org/jira/browse/BEAM-5063 > Project: Beam > Issue Type: Bug > Components: io-java-kinesis > Affects Versions: 2.5.0 > Reporter: Krzysztof Trubalski > Assignee: Jean-Baptiste Onofr=C3=A9 > Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > We have a Dataflow Job copying data from multiple Kinesis streams into Bi= g Query. Recently we have noticed that the watermark on one of the streams = frequently gets stuck although data from that stream is still being process= ed (it progress only when the traffic increases or Dataflow autoscaling fea= ture kicks in). > =C2=A0 > Looking at the CloudWatch statistics for the affected stream, it has a r= eally low traffic rate - only ~1 event every few minutes . After investigat= ion and consulting the issue with Google's Dataflow Team, it looks like wit= h such small amount of data on the stream, the function calculating the wat= ermark in KinesisReader reports progress incorrectly. > =C2=A0 > From my initial investigation, I suspect that the issue might be related= to usage of MovingFunction in KinesisReader.=C2=A0In the current implement= ation, it covers 1 minute period of samples,=C2=A0since obtaining the min v= alue flushes stale values, if the traffic is very low the following call to= significance check always returns false (as it relies on the number of sam= ples, and most of them were flushed by get() invocation). > =C2=A0 > =C2=A0 > =C2=A0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)