beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5193) KuduIO testWrite not correctly verifying behaviour
Date Wed, 22 Aug 2018 11:23:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5193?focusedWorklogId=136897&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136897
]

ASF GitHub Bot logged work on BEAM-5193:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/Aug/18 11:22
            Start Date: 22/Aug/18 11:22
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on issue #6263: [BEAM-5193] Correct typos in KuduIOTest
testWrite
URL: https://github.com/apache/beam/pull/6263#issuecomment-414999384
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 136897)
    Time Spent: 0.5h  (was: 20m)

> KuduIO testWrite not correctly verifying behaviour
> --------------------------------------------------
>
>                 Key: BEAM-5193
>                 URL: https://issues.apache.org/jira/browse/BEAM-5193
>             Project: Beam
>          Issue Type: Bug
>          Components: io-ideas
>    Affects Versions: 2.6.0
>            Reporter: Tim Robertson
>            Assignee: Tim Robertson
>            Priority: Major
>             Fix For: 2.7.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The {{testWrite}} in {{KuduIOTest}} has 2 typos which were committed in error.
> The following code block
> {code:java}
>     for (int i = 1; i <= targetParallelism + 1; i++) {
>       expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
>       expectedWriteLogs.verifyDebug(
>           String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
>       expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
>     }
>     // verify all entries written
>     for (int n = 0; n > numberRecords; n++) {
>       expectedWriteLogs.verifyDebug(
>           String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
>     }
> {code}
>  
> Should have read:
> {code:java}
>     for (int i = 1; i <= targetParallelism ; i++) {
>       expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_OPEN_SESSION, i));
>       expectedWriteLogs.verifyDebug(
>           String.format(FakeWriter.LOG_WRITE, i)); // at least one per writer
>       expectedWriteLogs.verifyDebug(String.format(FakeWriter.LOG_CLOSE_SESSION, i));
>     }
>     // verify all entries written
>     for (int n = 0; n < numberRecords; n++) {
>       expectedWriteLogs.verifyDebug(
>           String.format(FakeWriter.LOG_WRITE_VALUE, n)); // at least one per writer
>     }
> {code}
> This has gone unnoticed because 1) the {{targetParallelism}} is a function of cores available,
and the test uses 3 only (which is the min in {{DirectRunner}}) and 2) the incorrect {{>}}
in the test simply meant the loop was not run.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message