beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5092) Nexmark 10x performance regression
Date Thu, 09 Aug 2018 02:32:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5092?focusedWorklogId=132811&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-132811
]

ASF GitHub Bot logged work on BEAM-5092:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Aug/18 02:31
            Start Date: 09/Aug/18 02:31
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on a change in pull request #6176: [[BEAM-5092]
Row comparison should be faster when both are POJOs.
URL: https://github.com/apache/beam/pull/6176#discussion_r208791585
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/values/RowWithGetters.java
 ##########
 @@ -123,4 +124,27 @@ public int getFieldCount() {
   public Object getGetterTarget() {
     return getterTarget;
   }
+
+  @Override
+  public boolean equals(Object o) {
+    if (this == o) {
+      return true;
+    }
+    if (o == null) {
+      return false;
+    }
+    if (o instanceof RowWithGetters) {
+      RowWithGetters other = (RowWithGetters) o;
+      return Objects.equals(getSchema(), other.getSchema())
+          && Objects.equals(getterTarget, other.getterTarget);
 
 Review comment:
   1. The documentation for the currently supported getterTargets (JavaFieldSchema, JavaBeanSchema)
currently declare that equals() is required to be declared. Longer term we can detect whether
equals is declared, and if not we can generate a (slower) equals method.
   
   2. This is an interesting point. For now I will document the requirements, when we handle
this more generally per 1. I think we need to provide a way to deal with this.
   
   3. Currently the target cannot be an array. It can only be a POJO or a Java Bean.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 132811)
    Time Spent: 4h 40m  (was: 4.5h)

> Nexmark 10x performance regression
> ----------------------------------
>
>                 Key: BEAM-5092
>                 URL: https://issues.apache.org/jira/browse/BEAM-5092
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-java-core
>            Reporter: Andrew Pilloud
>            Assignee: Reuven Lax
>            Priority: Critical
>          Time Spent: 4h 40m
>  Remaining Estimate: 0h
>
> There looks to be a 10x performance hit on the DirectRunner and Flink nexmark jobs.
It first showed up in this build:
> [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_Nexmark_Direct/151/changes]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5084698770407424]
> [https://apache-beam-testing.appspot.com/explore?dashboard=5699257587728384]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message