beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-5070) nexmark.sources.UnboundedEventSourceTest.resumeFromCheckpoint is flaky
Date Tue, 14 Aug 2018 20:23:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-5070?focusedWorklogId=134700&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-134700
]

ASF GitHub Bot logged work on BEAM-5070:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Aug/18 20:22
            Start Date: 14/Aug/18 20:22
    Worklog Time Spent: 10m 
      Work Description: Ardagan commented on issue #6224: [BEAM-5070] Disable resumeFromCheckpoint
test due to flakiness
URL: https://github.com/apache/beam/pull/6224#issuecomment-413003162
 
 
   Basically yes:
   1. Find failure
   2. Create Jira
   3. ...
   4. if test flakes too often, decide on disabling -> disable (Keep Jira open)
   5. Fix test, send PR with fix + enabling test
   6. Merge PR, if it is flake, then give it some time to validate fix. (I'd say a week)
   7. Close Jira.
   
   I didn't document [this explicitly](https://beam.apache.org/contribute/postcommits-guides/index.html#disabling)
on policies page, since it is really granular. We can do that, but I believe that becomes
too much details.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 134700)
    Time Spent: 1h 10m  (was: 1h)

> nexmark.sources.UnboundedEventSourceTest.resumeFromCheckpoint is flaky
> ----------------------------------------------------------------------
>
>                 Key: BEAM-5070
>                 URL: https://issues.apache.org/jira/browse/BEAM-5070
>             Project: Beam
>          Issue Type: Bug
>          Components: test-failures
>    Affects Versions: 2.5.0
>            Reporter: Reuven Lax
>            Assignee: Anton Kedin
>            Priority: Critical
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This test fails fairly frequently.
> History: [https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_GradleBuild/1219/testReport/junit/org.apache.beam.sdk.nexmark.sources/UnboundedEventSourceTest/resumeFromCheckpoint/history/]
>  Sample job: https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Java_GradleBuild/1219/testReport/org.apache.beam.sdk.nexmark.sources/UnboundedEventSourceTest/resumeFromCheckpoint/
> Failure log:
> org.junit.ComparisonFailure: expected:<...":"UTC"},"afterNow":[true,"beforeNow":fals]e,"equalNow":false},...>
but was:<...":"UTC"},"afterNow":[false,"beforeNow":tru]e,"equalNow":false},...> at org.junit.Assert.assertEquals(Assert.java:115)
at org.junit.Assert.assertEquals(Assert.java:144) at org.apache.beam.sdk.nexmark.sources.UnboundedEventSourceTest$EventIdChecker.add(UnboundedEventSourceTest.java:71)
at org.apache.beam.sdk.nexmark.sources.UnboundedEventSourceTest.resumeFromCheckpoint(UnboundedEventSourceTest.java:96)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message