beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-4761) Add postCommit scripts and perfkit dashboards for nexmark on Dataflow runner
Date Thu, 02 Aug 2018 21:25:00 GMT


ASF GitHub Bot logged work on BEAM-4761:

                Author: ASF GitHub Bot
            Created on: 02/Aug/18 21:24
            Start Date: 02/Aug/18 21:24
    Worklog Time Spent: 10m 
      Work Description: amaliujia commented on a change in pull request #6127: [BEAM-4761]
Run Nexmark in thread pool

 File path: sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/
 @@ -107,6 +178,9 @@ void runAll(OptionT options, NexmarkLauncher nexmarkLauncher) throws
         saveSummary(options.getSummaryFilename(), configurations, actual, baseline, start,
         saveJavascript(options.getJavascriptFilename(), configurations, actual, baseline,
+      executor.shutdown();
+      while (!executor.isTerminated()) {}
 Review comment:
   I tend to avoid waiting for one thing without timeout. In case by any chance it never returns
(or most likely takes too long time to return).  [awaitTermination](
is a better choice.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 130645)
    Time Spent: 4h  (was: 3h 50m)

> Add postCommit scripts and perfkit dashboards for nexmark on Dataflow runner
> ----------------------------------------------------------------------------
>                 Key: BEAM-4761
>                 URL:
>             Project: Beam
>          Issue Type: Test
>          Components: examples-nexmark
>            Reporter: Etienne Chauchot
>            Assignee: Andrew Pilloud
>            Priority: Major
>          Time Spent: 4h
>  Remaining Estimate: 0h

This message was sent by Atlassian JIRA

View raw message