beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4006) Futurize and fix python 2 compatibility for transforms subpackage
Date Thu, 02 Aug 2018 00:09:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=130026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130026
]

ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/18 00:08
            Start Date: 02/Aug/18 00:08
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5729: [BEAM-4006]
Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r207065158
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/core.py
 ##########
 @@ -1712,6 +1718,10 @@ def __eq__(self, other):
           and self.timestamp_combiner == other.timestamp_combiner)
     return False
 
+  def __hash__(self):
+    return hash((type(self), self.windowfn, self.accumulation_mode,
 
 Review comment:
   Since this was not defined, most likely this will be dead code, and current implementation
may break the contract with `__eq__` since it's not taking `self._default` into account, let's
make it `__hash__ = None`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 130026)
    Time Spent: 15h  (was: 14h 50m)

> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
>                 Key: BEAM-4006
>                 URL: https://issues.apache.org/jira/browse/BEAM-4006
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 15h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message