beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4006) Futurize and fix python 2 compatibility for transforms subpackage
Date Thu, 02 Aug 2018 00:09:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=130024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-130024
]

ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Aug/18 00:08
            Start Date: 02/Aug/18 00:08
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5729: [BEAM-4006]
Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r207065689
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/window.py
 ##########
 @@ -246,10 +273,23 @@ def __init__(self, value, timestamp):
     self.value = value
     self.timestamp = Timestamp.of(timestamp)
 
-  def __cmp__(self, other):
-    if type(self) is not type(other):
-      return cmp(type(self), type(other))
-    return cmp((self.value, self.timestamp), (other.value, other.timestamp))
+  def __eq__(self, other):
+    return (type(self) == type(other)
+            and self.value == other.value
+            and self.timestamp == other.timestamp)
+
+  def __hash__(self):
+    return hash((type(self), self.value, self.timestamp))
 
 Review comment:
   Let's remove `type(self)` from the tuple.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 130024)
    Time Spent: 14h 40m  (was: 14.5h)

> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
>                 Key: BEAM-4006
>                 URL: https://issues.apache.org/jira/browse/BEAM-4006
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 14h 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message