beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3026) Improve retrying in ElasticSearch client
Date Tue, 21 Aug 2018 14:35:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3026?focusedWorklogId=136536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-136536
]

ASF GitHub Bot logged work on BEAM-3026:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Aug/18 14:34
            Start Date: 21/Aug/18 14:34
    Worklog Time Spent: 10m 
      Work Description: echauchot edited a comment on issue #6146: [BEAM-3026] Adding retrying
behavior on ElasticSearchIO
URL: https://github.com/apache/beam/pull/6146#issuecomment-414695115
 
 
   @aalbatross please do not squash your commits until the end of the review (just after LGTM)
it is very difficult to follow review commits otherwise. Also, as an advice try to have as
small commits (by still coherent) as possible it simplifies the reading of your code path
 at the following of review comments. At the end a sole feature comment is fine as long as
it is the good isolation size (retry feature is).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 136536)
    Time Spent: 11h 10m  (was: 11h)

> Improve retrying in ElasticSearch client
> ----------------------------------------
>
>                 Key: BEAM-3026
>                 URL: https://issues.apache.org/jira/browse/BEAM-3026
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-elasticsearch
>            Reporter: Tim Robertson
>            Assignee: Ravi Pathak
>            Priority: Major
>             Fix For: 2.7.0
>
>          Time Spent: 11h 10m
>  Remaining Estimate: 0h
>
> Currently an overloaded ES server will result in clients failing fast.
> I suggest implementing backoff pauses.  Perhaps something like this:
> {code}
>     ElasticsearchIO.ConnectionConfiguration conn = ElasticsearchIO.ConnectionConfiguration
>       .create(new String[]{"http://...:9200"}, "test", "test")
>       .retryWithWaitStrategy(WaitStrategies.exponentialBackoff(1000, TimeUnit.MILLISECONDS)
>       .retryWithStopStrategy(StopStrategies.stopAfterAttempt(10)
>     );
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message