From commits-return-85514-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Jul 27 18:29:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3B7DD180679 for ; Fri, 27 Jul 2018 18:29:06 +0200 (CEST) Received: (qmail 98368 invoked by uid 500); 27 Jul 2018 16:29:05 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 98359 invoked by uid 99); 27 Jul 2018 16:29:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jul 2018 16:29:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D400B1A256E for ; Fri, 27 Jul 2018 16:29:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id DgFb0yZh4jrQ for ; Fri, 27 Jul 2018 16:29:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B0D8B5F39F for ; Fri, 27 Jul 2018 16:29:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id D91DEE25FE for ; Fri, 27 Jul 2018 16:29:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4523427762 for ; Fri, 27 Jul 2018 16:29:00 +0000 (UTC) Date: Fri, 27 Jul 2018 16:29:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-5037) HashFunction is not intialized in SyntheticOptions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-5037?focusedWorklogId=3D1= 28199&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-128199 ] ASF GitHub Bot logged work on BEAM-5037: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Jul/18 16:28 Start Date: 27/Jul/18 16:28 Worklog Time Spent: 10m=20 Work Description: pabloem commented on issue #6083: [BEAM-5037] fix s= ynthetic options URL: https://github.com/apache/beam/pull/6083#issuecomment-408470748 =20 =20 This makes sense to me. LGTM. Feel free to merge after precommits stop f= laking. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 128199) Time Spent: 40m (was: 0.5h) > HashFunction is not intialized in SyntheticOptions > -------------------------------------------------- > > Key: BEAM-5037 > URL: https://issues.apache.org/jira/browse/BEAM-5037 > Project: Beam > Issue Type: Bug > Components: testing > Reporter: Lukasz Gajowy > Assignee: Lukasz Gajowy > Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > > This is due to fact that the field is transient hence not getting seriali= zed and then initialized again after deserialization. We need some other wa= y of initializing it, immune to the field's transiency. > Stacktrace: > {code:java} > Class org.apache.beam.sdk.io.synthetic.GroupByKeyLoadIT > all=C2=A0>=C2=A0org.apache.beam.sdk.io.synthetic=C2=A0> GroupByKeyLoadIT > 1 > tests > 1 > failures > 0 > ignored > 0.050s > duration > 0% > successful > Failed tests > Tests > Standard error > groupByKeyLoadTest > java.lang.IllegalArgumentException: hashFunction hasn't been initialized. > =09at com.google.common.base.Preconditions.checkArgument(Preconditions.ja= va:122) > =09at org.apache.beam.sdk.io.synthetic.SyntheticOptions.validate(Syntheti= cOptions.java:301) > =09at org.apache.beam.sdk.io.synthetic.SyntheticBoundedIO$SyntheticSource= Options.validate(SyntheticBoundedIO.java:285) > =09at org.apache.beam.sdk.io.synthetic.SyntheticBoundedIO$SyntheticBounde= dSource.validate(SyntheticBoundedIO.java:119) > =09at org.apache.beam.sdk.io.Read$Bounded.expand(Read.java:95) > =09at org.apache.beam.sdk.io.Read$Bounded.expand(Read.java:85) > =09at org.apache.beam.sdk.Pipeline.applyInternal(Pipeline.java:537) > =09at org.apache.beam.sdk.Pipeline.applyTransform(Pipeline.java:471) > =09at org.apache.beam.sdk.values.PBegin.apply(PBegin.java:44) > =09at org.apache.beam.sdk.Pipeline.apply(Pipeline.java:167) > =09at org.apache.beam.sdk.io.synthetic.GroupByKeyLoadIT.groupByKeyLoadTes= t(GroupByKeyLoadIT.java:81) > =09at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > =09at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImp= l.java:62) > =09at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcc= essorImpl.java:43) > =09at java.lang.reflect.Method.invoke(Method.java:498) > =09at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(Framewo= rkMethod.java:50) > =09at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveC= allable.java:12) > =09at org.junit.runners.model.FrameworkMethod.invokeExplosively(Framework= Method.java:47) > =09at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeM= ethod.java:17) > =09at org.apache.beam.sdk.testing.TestPipeline$1.evaluate(TestPipeline.ja= va:319) > =09at org.junit.rules.RunRules.evaluate(RunRules.java:20) > =09at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325) > =09at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassR= unner.java:78) > =09at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassR= unner.java:57) > =09at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290) > =09at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71) > =09at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288) > =09at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58) > =09at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268) > =09at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefore= s.java:26) > =09at org.junit.runners.ParentRunner.run(ParentRunner.java:363) > =09at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.= runTestClass(JUnitTestClassExecutor.java:106) > =09at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.= execute(JUnitTestClassExecutor.java:58) > =09at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.= execute(JUnitTestClassExecutor.java:38) > =09at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassP= rocessor.processTestClass(AbstractJUnitTestClassProcessor.java:66) > =09at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.proce= ssTestClass(SuiteTestClassProcessor.java:51) > =09at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > =09at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImp= l.java:62) > =09at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcc= essorImpl.java:43) > =09at java.lang.reflect.Method.invoke(Method.java:498) > =09at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(Reflection= Dispatch.java:35) > =09at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(Reflection= Dispatch.java:24) > =09at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(Co= ntextClassLoaderDispatch.java:32) > =09at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvoca= tionHandler.invoke(ProxyDispatchAdapter.java:93) > =09at com.sun.proxy.$Proxy1.processTestClass(Unknown Source) > =09at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTest= Class(TestWorker.java:109) > =09at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > =09at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImp= l.java:62) > =09at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAcc= essorImpl.java:43) > =09at java.lang.reflect.Method.invoke(Method.java:498) > =09at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(Reflection= Dispatch.java:35) > =09at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(Reflection= Dispatch.java:24) > =09at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConne= ction$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:155) > =09at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConne= ction$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:137) > =09at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(Mess= ageHub.java:404) > =09at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailure= s.onExecute(ExecutorPolicy.java:63) > =09at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExe= cutorImpl.java:46) > =09at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecuto= r.java:1142) > =09at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecut= or.java:617) > =09at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunna= ble.run(ThreadFactoryImpl.java:55) > =09at java.lang.Thread.run(Thread.java:745) > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)