From commits-return-82487-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Jul 6 21:06:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3D5FA180674 for ; Fri, 6 Jul 2018 21:06:04 +0200 (CEST) Received: (qmail 76329 invoked by uid 500); 6 Jul 2018 19:06:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 76320 invoked by uid 99); 6 Jul 2018 19:06:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 06 Jul 2018 19:06:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id C7557186AFA for ; Fri, 6 Jul 2018 19:06:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id Cyzkyb4rcBDT for ; Fri, 6 Jul 2018 19:06:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 42C9F5F124 for ; Fri, 6 Jul 2018 19:06:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 7F4FCE0EE1 for ; Fri, 6 Jul 2018 19:06:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 4021627509 for ; Fri, 6 Jul 2018 19:06:00 +0000 (UTC) Date: Fri, 6 Jul 2018 19:06:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4727) Reduce metrics overhead MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4727?focusedWorklogId=119988&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-119988 ] ASF GitHub Bot logged work on BEAM-4727: ---------------------------------------- Author: ASF GitHub Bot Created on: 06/Jul/18 19:05 Start Date: 06/Jul/18 19:05 Worklog Time Spent: 10m Work Description: lostluck commented on issue #5884: [BEAM-4727] Re-use metric context throughout bundle URL: https://github.com/apache/beam/pull/5884#issuecomment-403121189 PTAL @wcn3 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 119988) Time Spent: 1.5h (was: 1h 20m) > Reduce metrics overhead > ----------------------- > > Key: BEAM-4727 > URL: https://issues.apache.org/jira/browse/BEAM-4727 > Project: Beam > Issue Type: Sub-task > Components: sdk-go > Reporter: Robert Burke > Assignee: Robert Burke > Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > > There are a few opportunities to avoid metrics overhead. > First when setting state in the context, we allocate a new one for the stored value, per element. This generates a fair amount of objects for the garbage collector too. If we retain and re-use contexts within a bundle, we would have the opportunity to save on these costs. > Also, it's possible that we have overhead on the metric updating paths. We can possibly do better than the general sync.Map, and avoid the type assertion cost for extracting values of known types from the maps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)