From commits-return-82942-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue Jul 10 23:46:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 2BBA4180634 for ; Tue, 10 Jul 2018 23:46:03 +0200 (CEST) Received: (qmail 4425 invoked by uid 500); 10 Jul 2018 21:46:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 4416 invoked by uid 99); 10 Jul 2018 21:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 10 Jul 2018 21:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id CEC26C0110 for ; Tue, 10 Jul 2018 21:46:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id FG1Uk8LZrfq1 for ; Tue, 10 Jul 2018 21:46:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 263AF5F1B7 for ; Tue, 10 Jul 2018 21:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 923EDE02EB for ; Tue, 10 Jul 2018 21:46:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1587821EEA for ; Tue, 10 Jul 2018 21:46:00 +0000 (UTC) Date: Tue, 10 Jul 2018 21:46:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4562) [SQL] Fix INSERT VALUES in JdbcDriver MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4562?focusedWorklogId=3D1= 21634&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-121634 ] ASF GitHub Bot logged work on BEAM-4562: ---------------------------------------- Author: ASF GitHub Bot Created on: 10/Jul/18 21:45 Start Date: 10/Jul/18 21:45 Worklog Time Spent: 10m=20 Work Description: apilloud opened a new pull request #5918: BEAM-4562= BEAM-4700: [SQL] Fix INSERT VALUES and timezone issues URL: https://github.com/apache/beam/pull/5918 =20 =20 This fixes the critical SQL issues: * BEAM-4562: INSERT values not working * BEAM-4700: Timezone offset being applied to timestamp without timezon= e =20 ------------------------ =20 Follow this checklist to help us incorporate your contribution quickly a= nd easily: =20 - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in Appro= ximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA is= sue, if applicable. This will automatically link the pull request to the is= sue. - [ ] If this contribution is large, please file an Apache [Individual = Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). =20 It will help us expedite review of your Pull Request if you tag someone = (e.g. `@username`) to look at it. =20 Post-Commit Tests Status (on master branch) ------------------------------------------------------------------------= ------------------------ =20 Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark --- | --- | --- | --- | --- | --- | --- | --- Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_G= radleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/be= am_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- |= --- | --- Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Ja= va_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/jo= b/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](= https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gra= dle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_Post= Commit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Sta= tus](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dat= aflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/= beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) |= [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_Valida= tesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apach= e.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBu= ild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java= _ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://bu= ilds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/la= stCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_Po= stCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](= https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gr= adle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/= beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/= icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_S= park_Gradle/lastCompletedBuild/) Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_= Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job= /beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status= ](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastComplete= dBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dat= aflow/lastCompletedBuild/)
[![Build Status](https://builds.apache.org= /job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://bui= lds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | --- | = --- | --- | --- =20 =20 =20 =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 121634) Time Spent: 10m Remaining Estimate: 0h > [SQL] Fix INSERT VALUES in JdbcDriver=20 > -------------------------------------- > > Key: BEAM-4562 > URL: https://issues.apache.org/jira/browse/BEAM-4562 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Anton Kedin > Assignee: Andrew Pilloud > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > Executing INSERT VALUES against JdbcDriver fails. Executing similar state= ments against BeamSqlEnv works fine. Example: > {code:java} > TestTableProvider tableProvider =3D new TestTableProvider(); > Connection connection =3D JdbcDriver.connect(tableProvider); > connection > .createStatement() > .executeUpdate("CREATE TABLE person (id BIGINT, name VARCHAR) TYP= E 'test'"); > connection.createStatement().executeQuery("INSERT INTO person VALUES(= 3, 'yyy')"); > {code} > =C2=A0Output: > {code} > java.sql.SQLException: Error while executing SQL "INSERT INTO person VALU= ES(3, 'yyy')": Node [rel#9:Subset#1.ENUMERABLE.[]] could not be implemented= ; planner state: > Root: rel#9:Subset#1.ENUMERABLE.[] > Original rel: > BeamIOSinkRel(subset=3D[rel#9:Subset#1.ENUMERABLE.[]], table=3D[[beam, pe= rson]], operation=3D[INSERT], flattened=3D[false]): rowcount =3D 1.0, cumul= ative cost =3D {1.0 rows, 0.0 cpu, 0.0 io}, id =3D 6 > LogicalValues(subset=3D[rel#5:Subset#0.NONE.[]], tuples=3D[[{ 3, 'yyy' = }]]): rowcount =3D 1.0, cumulative cost =3D {1.0 rows, 1.0 cpu, 0.0 io}, id= =3D 0 > Sets: > Set#0, type: RecordType(BIGINT id, VARCHAR name) > =09rel#5:Subset#0.NONE.[], best=3Dnull, importance=3D0.81 > =09=09rel#0:LogicalValues.NONE.[[0, 1], [1]](type=3DRecordType(BIGINT id,= VARCHAR name),tuples=3D[{ 3, 'yyy' }]), rowcount=3D1.0, cumulative cost=3D= {inf} > =09rel#14:Subset#0.BEAM_LOGICAL.[], best=3Dnull, importance=3D0.81 > =09rel#20:Subset#0.ENUMERABLE.[], best=3Drel#19, importance=3D0.405 > =09=09rel#19:EnumerableValues.ENUMERABLE.[[0, 1], [1]](type=3DRecordType(= BIGINT id, VARCHAR name),tuples=3D[{ 3, 'yyy' }]), rowcount=3D1.0, cumulati= ve cost=3D{1.0 rows, 1.0 cpu, 0.0 io} > Set#1, type: RecordType(BIGINT ROWCOUNT) > =09rel#7:Subset#1.BEAM_LOGICAL.[], best=3Dnull, importance=3D0.9 > =09=09rel#6:BeamIOSinkRel.BEAM_LOGICAL.[](input=3Drel#5:Subset#0.NONE.[],= table=3D[beam, person],operation=3DINSERT,flattened=3Dfalse), rowcount=3D1.= 0, cumulative cost=3D{inf} > =09=09rel#15:BeamIOSinkRel.BEAM_LOGICAL.[](input=3Drel#14:Subset#0.BEAM_L= OGICAL.[],table=3D[beam, person],operation=3DINSERT,flattened=3Dfalse), row= count=3D1.0, cumulative cost=3D{inf} > =09rel#9:Subset#1.ENUMERABLE.[], best=3Dnull, importance=3D1.0 > =09=09rel#10:AbstractConverter.ENUMERABLE.[](input=3Drel#7:Subset#1.BEAM_= LOGICAL.[],convention=3DENUMERABLE,sort=3D[]), rowcount=3D1.0, cumulative c= ost=3D{inf} > =09=09rel#11:BeamEnumerableConverter.ENUMERABLE.[](input=3Drel#7:Subset#1= .BEAM_LOGICAL.[]), rowcount=3D1.0, cumulative cost=3D{inf}{code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)