From commits-return-84261-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Jul 20 10:54:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1A71418067A for ; Fri, 20 Jul 2018 10:54:04 +0200 (CEST) Received: (qmail 92332 invoked by uid 500); 20 Jul 2018 08:54:04 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 92322 invoked by uid 99); 20 Jul 2018 08:54:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Jul 2018 08:54:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id AE8B218096A for ; Fri, 20 Jul 2018 08:54:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id AX3MrJFqjyCs for ; Fri, 20 Jul 2018 08:54:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 174235F300 for ; Fri, 20 Jul 2018 08:54:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5C57CE09A5 for ; Fri, 20 Jul 2018 08:54:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1DCD82713C for ; Fri, 20 Jul 2018 08:54:00 +0000 (UTC) Date: Fri, 20 Jul 2018 08:54:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4006) Futurize and fix python 2 compatibility for transforms subpackage MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=125399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125399 ] ASF GitHub Bot logged work on BEAM-4006: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Jul/18 08:53 Start Date: 20/Jul/18 08:53 Worklog Time Spent: 10m Work Description: Fematich commented on a change in pull request #5729: [BEAM-4006] Futurize transforms subpackage URL: https://github.com/apache/beam/pull/5729#discussion_r203978611 ########## File path: sdks/python/apache_beam/transforms/core.py ########## @@ -1906,7 +1920,7 @@ def __init__(self, value): value: An object of values for the PCollection """ super(Create, self).__init__() - if isinstance(value, string_types): + if isinstance(value, (unicode, str, bytes)): Review comment: See https://github.com/apache/beam/pull/5729#discussion_r199660012. Bytes in Python3 also shouldn't be allowed since we don't want to support creation of a PCollection of single bytes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 125399) Time Spent: 7.5h (was: 7h 20m) > Futurize and fix python 2 compatibility for transforms subpackage > ----------------------------------------------------------------- > > Key: BEAM-4006 > URL: https://issues.apache.org/jira/browse/BEAM-4006 > Project: Beam > Issue Type: Sub-task > Components: sdk-py-core > Reporter: Robbe > Assignee: Matthias Feys > Priority: Major > Time Spent: 7.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.3#76005)