beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-4813) Make Go Dataflow translation use protos directly
Date Mon, 30 Jul 2018 16:48:00 GMT


ASF GitHub Bot logged work on BEAM-4813:

                Author: ASF GitHub Bot
            Created on: 30/Jul/18 16:47
            Start Date: 30/Jul/18 16:47
    Worklog Time Spent: 10m 
      Work Description: herohde commented on a change in pull request #5994:  [BEAM-4813]
Refactor Go Dataflow runner and translation

 File path: sdks/go/pkg/beam/core/util/stringx/map.go
 @@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements.  See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License.  You may obtain a copy of the License at
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package stringx
+// Keys returns the domain of a map[string]string.
+func Keys(m map[string]string) []string {
+	var keys []string
+	for k := range m {
+		keys = append(keys, k)
+	}
+	return keys
+// AnyKey returns a key of a map[string]string. Panics
+// if the map is empty.
+func AnyKey(m map[string]string) string {
+	for k := range m {
 Review comment:
   Sad we're removing it then ;)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 128793)
    Time Spent: 3.5h  (was: 3h 20m)

> Make Go Dataflow translation use protos directly
> ------------------------------------------------
>                 Key: BEAM-4813
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Major
>          Time Spent: 3.5h
>  Remaining Estimate: 0h
> The Go SDK maintains 2 pipeline translations and keeps various tweaks in sync. It would
be better to remove the Dataflow one and extract a more flexible (such as running as a separate
proxy) translation from proto to v1beta3.

This message was sent by Atlassian JIRA

View raw message