beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4562) [SQL] Fix INSERT VALUES in JdbcDriver
Date Tue, 10 Jul 2018 21:46:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4562?focusedWorklogId=121634&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-121634
]

ASF GitHub Bot logged work on BEAM-4562:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jul/18 21:45
            Start Date: 10/Jul/18 21:45
    Worklog Time Spent: 10m 
      Work Description: apilloud opened a new pull request #5918: BEAM-4562 BEAM-4700: [SQL]
Fix INSERT VALUES and timezone issues
URL: https://github.com/apache/beam/pull/5918
 
 
   This fixes the critical SQL issues:
    * BEAM-4562: INSERT values not working
    * BEAM-4700: Timezone offset being applied to timestamp without timezone
   
   ------------------------
   
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically
link the pull request to the issue.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
   
   It will help us expedite review of your Pull Request if you tag someone (e.g. `@username`)
to look at it.
   
   Post-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
   Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/)
| [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/)
| [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/)
| [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/)
| [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/)
| [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/)
| [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)
   Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)
| --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
</br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| --- | --- | --- | ---
   
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 121634)
            Time Spent: 10m
    Remaining Estimate: 0h

> [SQL] Fix INSERT VALUES in JdbcDriver 
> --------------------------------------
>
>                 Key: BEAM-4562
>                 URL: https://issues.apache.org/jira/browse/BEAM-4562
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Anton Kedin
>            Assignee: Andrew Pilloud
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Executing INSERT VALUES against JdbcDriver fails. Executing similar statements against
BeamSqlEnv works fine. Example:
> {code:java}
>     TestTableProvider tableProvider = new TestTableProvider();
>     Connection connection = JdbcDriver.connect(tableProvider);
>     connection
>         .createStatement()
>         .executeUpdate("CREATE TABLE person (id BIGINT, name VARCHAR) TYPE 'test'");
>     connection.createStatement().executeQuery("INSERT INTO person VALUES(3, 'yyy')");
> {code}
>  Output:
> {code}
> java.sql.SQLException: Error while executing SQL "INSERT INTO person VALUES(3, 'yyy')":
Node [rel#9:Subset#1.ENUMERABLE.[]] could not be implemented; planner state:
> Root: rel#9:Subset#1.ENUMERABLE.[]
> Original rel:
> BeamIOSinkRel(subset=[rel#9:Subset#1.ENUMERABLE.[]], table=[[beam, person]], operation=[INSERT],
flattened=[false]): rowcount = 1.0, cumulative cost = {1.0 rows, 0.0 cpu, 0.0 io}, id = 6
>   LogicalValues(subset=[rel#5:Subset#0.NONE.[]], tuples=[[{ 3, 'yyy' }]]): rowcount =
1.0, cumulative cost = {1.0 rows, 1.0 cpu, 0.0 io}, id = 0
> Sets:
> Set#0, type: RecordType(BIGINT id, VARCHAR name)
> 	rel#5:Subset#0.NONE.[], best=null, importance=0.81
> 		rel#0:LogicalValues.NONE.[[0, 1], [1]](type=RecordType(BIGINT id, VARCHAR name),tuples=[{
3, 'yyy' }]), rowcount=1.0, cumulative cost={inf}
> 	rel#14:Subset#0.BEAM_LOGICAL.[], best=null, importance=0.81
> 	rel#20:Subset#0.ENUMERABLE.[], best=rel#19, importance=0.405
> 		rel#19:EnumerableValues.ENUMERABLE.[[0, 1], [1]](type=RecordType(BIGINT id, VARCHAR
name),tuples=[{ 3, 'yyy' }]), rowcount=1.0, cumulative cost={1.0 rows, 1.0 cpu, 0.0 io}
> Set#1, type: RecordType(BIGINT ROWCOUNT)
> 	rel#7:Subset#1.BEAM_LOGICAL.[], best=null, importance=0.9
> 		rel#6:BeamIOSinkRel.BEAM_LOGICAL.[](input=rel#5:Subset#0.NONE.[],table=[beam, person],operation=INSERT,flattened=false),
rowcount=1.0, cumulative cost={inf}
> 		rel#15:BeamIOSinkRel.BEAM_LOGICAL.[](input=rel#14:Subset#0.BEAM_LOGICAL.[],table=[beam,
person],operation=INSERT,flattened=false), rowcount=1.0, cumulative cost={inf}
> 	rel#9:Subset#1.ENUMERABLE.[], best=null, importance=1.0
> 		rel#10:AbstractConverter.ENUMERABLE.[](input=rel#7:Subset#1.BEAM_LOGICAL.[],convention=ENUMERABLE,sort=[]),
rowcount=1.0, cumulative cost={inf}
> 		rel#11:BeamEnumerableConverter.ENUMERABLE.[](input=rel#7:Subset#1.BEAM_LOGICAL.[]),
rowcount=1.0, cumulative cost={inf}{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message