beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Cwik (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BEAM-4484) Shading model-pipeline / model-fn-execution / model-job-management produces corrupted classes
Date Tue, 10 Jul 2018 21:24:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Luke Cwik resolved BEAM-4484.
-----------------------------
       Resolution: Fixed
    Fix Version/s: 2.6.0

> Shading model-pipeline / model-fn-execution / model-job-management produces corrupted
classes
> ---------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4484
>                 URL: https://issues.apache.org/jira/browse/BEAM-4484
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>            Reporter: Luke Cwik
>            Assignee: Luke Cwik
>            Priority: Major
>             Fix For: 2.6.0
>
>
> During investigation for test failures on [https://github.com/apache/beam/pull/5445,] I discovered
that the the post shaded beam-model-pipeline proto filedescriptors were corrupted. It turns
out that during the shading process, an over eager string replacement inside a class is corrupting
an internal field, in this case it modifies the RunnerApi file descriptor storing
> {code:java}
> org.apache.beam.model.pipeline.v1.AccumulationMode.Enum{code}
> and changing it to
> {code:java}
> org.apache.beam.repackaged.beam_runners_direct_java.model.pipeline.v1.AccumulationMode.Enum{code}
> This problem exists because the proto package name and the java package name collide
and use org.apache.beam.model.pipeline.v1.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message