beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4176) Java: Portable batch runner passes all ValidatesRunner tests that non-portable runner passes
Date Wed, 18 Jul 2018 23:14:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=124685&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-124685
]

ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/Jul/18 23:13
            Start Date: 18/Jul/18 23:13
    Worklog Time Spent: 10m 
      Work Description: angoenka commented on a change in pull request #5935: [BEAM-4176]
Initial implementation for running portable runner tests
URL: https://github.com/apache/beam/pull/5935#discussion_r203559452
 
 

 ##########
 File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkJobServerDriver.java
 ##########
 @@ -45,9 +46,12 @@
   private final ListeningExecutorService executor;
   private final ServerConfiguration configuration;
   private final ServerFactory serverFactory;
+  private GrpcFnServer<InMemoryJobService> jobServer;
+  private GrpcFnServer<BeamFileSystemArtifactStagingService> artifactStagingServer;
 
-  private static class ServerConfiguration {
-    @Option(name = "--job-host", required = true, usage = "The job server host string")
+  /** Configuration for the jobServer. */
+  public static class ServerConfiguration {
+    @Option(name = "--job-host", usage = "The job server host string")
 
 Review comment:
   Ports can be chosen dynamically if not provided.
   This help facilitate launch of multiple jobServices on the same machine by finding an unused
port.
   
   Finding and managing unused ports reliably is surprisingly difficult. The major challenge
is that once you pick a port without using it, it can be picked and used by some other process
without your knowledge.
   
   Please let me know of any other ways/library to get dynamic unused ports in tests case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 124685)
    Time Spent: 40m  (was: 0.5h)

> Java: Portable batch runner passes all ValidatesRunner tests that non-portable runner
passes
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4176
>                 URL: https://issues.apache.org/jira/browse/BEAM-4176
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ben Sidhom
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message