beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4176) Java: Portable batch runner passes all ValidatesRunner tests that non-portable runner passes
Date Tue, 31 Jul 2018 00:57:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4176?focusedWorklogId=129057&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-129057
]

ASF GitHub Bot logged work on BEAM-4176:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Jul/18 00:56
            Start Date: 31/Jul/18 00:56
    Worklog Time Spent: 10m 
      Work Description: bsidhom commented on a change in pull request #6073: [BEAM-4176] Validate
Runner Tests generalization and enable for local reference runner
URL: https://github.com/apache/beam/pull/6073#discussion_r206366632
 
 

 ##########
 File path: buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
 ##########
 @@ -1389,5 +1402,39 @@ artifactId=${project.name}
         args argsNeeded
       }
     }
+
+
+    /** ***********************************************************************************************/
+
+    // Method to create the PortableValidatesRunnerTask.
+    project.ext.createPortableValidatesRunnerTask = {
+      def config = it ? it as PortableValidatesRunnerConfig : new PortableValidatesRunnerConfig()
+      def name = config.name ? config.name : "validatesPortableRunner"
+      def testCategories = {
+        includeCategories 'org.apache.beam.sdk.testing.ValidatesRunner'
+        excludeCategories 'org.apache.beam.sdk.testing.FlattenWithHeterogeneousCoders'
+        excludeCategories 'org.apache.beam.sdk.testing.LargeKeys$Above100MB'
+        excludeCategories 'org.apache.beam.sdk.testing.UsesCommittedMetrics'
+        excludeCategories 'org.apache.beam.sdk.testing.UsesGaugeMetrics'
+        excludeCategories 'org.apache.beam.sdk.testing.UsesDistributionMetrics'
+        excludeCategories 'org.apache.beam.sdk.testing.UsesAttemptedMetrics'
+        excludeCategories 'org.apache.beam.sdk.testing.UsesTimersInParDo'
+        excludeCategories 'org.apache.beam.sdk.testing.UsesTestStream'
+      }
+      testCategories = config.testCategories ? config.testCategories : testCategories
+      project.tasks.create(name: name, type: Test) {
+        group = "Verification"
+        description = "Validates the PortableRunner with JobServer ${config.jobServerDriver}"
+        systemProperty "beamTestPipelineOptions", JsonOutput.toJson([
+          "--runner=org.apache.beam.runners.reference.testing.TestPortableRunner",
+          "--jobServerDriver=${config.jobServerDriver}",
+          config.jobServerConfig ? "--jobServerConfig=${config.jobServerConfig}" : "",
+        ])
+        classpath = project.configurations.validatesPortableRunner
 
 Review comment:
   Please either document the requirement of the existence of a `validatesPortableRunner`
configuration or make the configuration pluggable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 129057)
    Time Spent: 7h 20m  (was: 7h 10m)

> Java: Portable batch runner passes all ValidatesRunner tests that non-portable runner
passes
> --------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4176
>                 URL: https://issues.apache.org/jira/browse/BEAM-4176
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>            Reporter: Ben Sidhom
>            Priority: Major
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> We need this as a sanity check that runner execution is correct.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message