beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4006) Futurize and fix python 2 compatibility for transforms subpackage
Date Fri, 20 Jul 2018 08:54:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4006?focusedWorklogId=125399&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-125399
]

ASF GitHub Bot logged work on BEAM-4006:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jul/18 08:53
            Start Date: 20/Jul/18 08:53
    Worklog Time Spent: 10m 
      Work Description: Fematich commented on a change in pull request #5729: [BEAM-4006]
Futurize transforms subpackage
URL: https://github.com/apache/beam/pull/5729#discussion_r203978611
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/core.py
 ##########
 @@ -1906,7 +1920,7 @@ def __init__(self, value):
       value: An object of values for the PCollection
     """
     super(Create, self).__init__()
-    if isinstance(value, string_types):
+    if isinstance(value, (unicode, str, bytes)):
 
 Review comment:
   See https://github.com/apache/beam/pull/5729#discussion_r199660012. Bytes in Python3 also
shouldn't be allowed since we don't want to support creation of a PCollection of single bytes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 125399)
    Time Spent: 7.5h  (was: 7h 20m)

> Futurize and fix python 2 compatibility for transforms subpackage
> -----------------------------------------------------------------
>
>                 Key: BEAM-4006
>                 URL: https://issues.apache.org/jira/browse/BEAM-4006
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 7.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message