From commits-return-78353-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue Jun 19 02:08:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 07D05180663 for ; Tue, 19 Jun 2018 02:08:03 +0200 (CEST) Received: (qmail 5047 invoked by uid 500); 19 Jun 2018 00:08:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 5037 invoked by uid 99); 19 Jun 2018 00:08:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Jun 2018 00:08:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id A4F171807DD for ; Tue, 19 Jun 2018 00:08:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id tNvDYy8hUxVE for ; Tue, 19 Jun 2018 00:08:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 306015F57E for ; Tue, 19 Jun 2018 00:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id AD607E0361 for ; Tue, 19 Jun 2018 00:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 1F32621832 for ; Tue, 19 Jun 2018 00:08:00 +0000 (UTC) Date: Tue, 19 Jun 2018 00:08:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4325) Enforce ErrorProne analysis in the SQL project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4325?focusedWorklogId=112957&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112957 ] ASF GitHub Bot logged work on BEAM-4325: ---------------------------------------- Author: ASF GitHub Bot Created on: 19/Jun/18 00:07 Start Date: 19/Jun/18 00:07 Worklog Time Spent: 10m Work Description: swegner commented on a change in pull request #5669: [BEAM-4325] Enforce ErrorProne analysis in the SQL project URL: https://github.com/apache/beam/pull/5669#discussion_r196261389 ########## File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/BeamSqlExpression.java ########## @@ -51,8 +51,8 @@ public SqlTypeName opType(int idx) { } public T opValueEvaluated( - int idx, Row row, BoundedWindow window, BeamSqlExpressionEnvironment env) { - return (T) op(idx).evaluate(row, window, env).getValue(); + Class clazz, int idx, Row row, BoundedWindow window, BeamSqlExpressionEnvironment env) { Review comment: I'm not a fan of this solution; it still seems like a misuse of the type system. In other places, I've removed the type parameter and returned an `Object` and let the callee cast it. Thoughts? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 112957) Time Spent: 40m (was: 0.5h) > Enforce ErrorProne analysis in the SQL project > ---------------------------------------------- > > Key: BEAM-4325 > URL: https://issues.apache.org/jira/browse/BEAM-4325 > Project: Beam > Issue Type: Improvement > Components: dsl-sql > Reporter: Scott Wegner > Assignee: Cade Markegard > Priority: Minor > Labels: errorprone, starter > Time Spent: 40m > Remaining Estimate: 0h > > Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-extensions-sql}}. Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E]. > Fixing this issue will involve: > # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development environment. > # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew :beam-sdks-java-extensions-sql:assemble}} > # Fix each ErrorProne warning from the {{sdks/java/extensions/sql}} project. > # In {{sdks/java/extensions/sql/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]). > This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/] with questions or code review: > * JIRA: [~swegner] > * GitHub: [@swegner|https://github.com/swegner] > * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel] > * Email: swegner at google dot com -- This message was sent by Atlassian JIRA (v7.6.3#76005)