From commits-return-77893-archive-asf-public=cust-asf.ponee.io@beam.apache.org Thu Jun 14 23:56:07 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id D9C3518066C for ; Thu, 14 Jun 2018 23:56:06 +0200 (CEST) Received: (qmail 57310 invoked by uid 500); 14 Jun 2018 21:56:05 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 57301 invoked by uid 99); 14 Jun 2018 21:56:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Jun 2018 21:56:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 55B2F1A0677 for ; Thu, 14 Jun 2018 21:56:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id 3IEGwSwNC1GY for ; Thu, 14 Jun 2018 21:56:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id CBBB75FC23 for ; Thu, 14 Jun 2018 21:56:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 14586E07FC for ; Thu, 14 Jun 2018 21:56:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 985482184D for ; Thu, 14 Jun 2018 21:56:00 +0000 (UTC) Date: Thu, 14 Jun 2018 21:56:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4309) Enforce ErrorProne analysis in direct-runner project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4309?focusedWorklogId=112068&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112068 ] ASF GitHub Bot logged work on BEAM-4309: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Jun/18 21:55 Start Date: 14/Jun/18 21:55 Worklog Time Spent: 10m Work Description: swegner commented on issue #5644: [BEAM-4309] Fix ErrorProne violations in direct runner URL: https://github.com/apache/beam/pull/5644#issuecomment-397450529 R: @iemejia ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 112068) Time Spent: 20m (was: 10m) > Enforce ErrorProne analysis in direct-runner project > ---------------------------------------------------- > > Key: BEAM-4309 > URL: https://issues.apache.org/jira/browse/BEAM-4309 > Project: Beam > Issue Type: Improvement > Components: runner-direct > Reporter: Scott Wegner > Assignee: Scott Wegner > Priority: Minor > Labels: errorprone, starter > Time Spent: 20m > Remaining Estimate: 0h > > Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-runners-direct-java}}. Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E]. > Fixing this issue will involve: > # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development environment. > # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew :beam-runners-direct-java:assemble}} > # Fix each ErrorProne warning from the {{runners/direct-java}} project. > # In {{runners/direct-java/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]). > This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/] with questions or code review: > * JIRA: [~swegner] > * GitHub: [@swegner|https://github.com/swegner] > * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel] > * Email: swegner at google dot com -- This message was sent by Atlassian JIRA (v7.6.3#76005)