From commits-return-78892-archive-asf-public=cust-asf.ponee.io@beam.apache.org Thu Jun 21 01:25:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 62EEF180648 for ; Thu, 21 Jun 2018 01:25:04 +0200 (CEST) Received: (qmail 21961 invoked by uid 500); 20 Jun 2018 23:25:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 21952 invoked by uid 99); 20 Jun 2018 23:25:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Jun 2018 23:25:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0DE9BC00C9 for ; Wed, 20 Jun 2018 23:25:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.501 X-Spam-Level: X-Spam-Status: No, score=-109.501 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id DIw5bo-0ii_I for ; Wed, 20 Jun 2018 23:25:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 7FDD85F431 for ; Wed, 20 Jun 2018 23:25:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id CDFFDE0950 for ; Wed, 20 Jun 2018 23:25:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 414772183B for ; Wed, 20 Jun 2018 23:25:00 +0000 (UTC) Date: Wed, 20 Jun 2018 23:25:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-3708) Implement the portable lifted Combiner transforms in Java SDK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3708?focusedWorklogId=3D1= 13970&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-113970 ] ASF GitHub Bot logged work on BEAM-3708: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Jun/18 23:24 Start Date: 20/Jun/18 23:24 Worklog Time Spent: 10m=20 Work Description: lukecwik commented on a change in pull request #562= 2: [BEAM-3708] Adding Combine component implementations to Java SDK URL: https://github.com/apache/beam/pull/5622#discussion_r196966761 =20 =20 ########## File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/Comb= ineRunners.java ########## @@ -0,0 +1,126 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied= . + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.beam.fn.harness; + +import com.google.auto.service.AutoService; +import com.google.common.collect.ImmutableMap; +import java.io.IOException; +import java.util.Map; +import org.apache.beam.model.pipeline.v1.RunnerApi.CombinePayload; +import org.apache.beam.model.pipeline.v1.RunnerApi.PTransform; +import org.apache.beam.model.pipeline.v1.RunnerApi.StandardPTransforms; +import org.apache.beam.runners.core.construction.BeamUrns; +import org.apache.beam.sdk.fn.function.ThrowingFunction; +import org.apache.beam.sdk.transforms.Combine.CombineFn; +import org.apache.beam.sdk.util.SerializableUtils; +import org.apache.beam.sdk.values.KV; + +/** + * Executes different components of Combine PTransforms. + */ +public class CombineRunners { + + private static final String PRECOMBINE_URN =3D =20 Review comment: Not much value in declaring these constants here again since they are us= ed in this class only once so directly reference them there. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 113970) > Implement the portable lifted Combiner transforms in Java SDK > ------------------------------------------------------------- > > Key: BEAM-3708 > URL: https://issues.apache.org/jira/browse/BEAM-3708 > Project: Beam > Issue Type: Sub-task > Components: sdk-java-core, sdk-java-harness > Reporter: Daniel Oliveira > Assignee: Daniel Oliveira > Priority: Major > Labels: portability > Time Spent: 40m > Remaining Estimate: 0h > > Lifted combines are split into=C2=A0separate parts with different=C2=A0UR= Ns. These parts need to be implemented in the Java SDK harness so that=C2= =A0the SDK can actually execute them when receiving=C2=A0Combine transforms= with the corresponding URNs. -- This message was sent by Atlassian JIRA (v7.6.3#76005)