beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4540) Hamcrest and JUnit are being leaked into the main path (should be test only)
Date Wed, 13 Jun 2018 15:38:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4540?focusedWorklogId=111533&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111533
]

ASF GitHub Bot logged work on BEAM-4540:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Jun/18 15:37
            Start Date: 13/Jun/18 15:37
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5604: [BEAM-4540]
Migrate junit/hamcrest to provided scope.
URL: https://github.com/apache/beam/pull/5604#discussion_r195133249
 
 

 ##########
 File path: sdks/java/fn-execution/build.gradle
 ##########
 @@ -37,6 +37,7 @@ dependencies {
   shadow library.java.grpc_stub
   shadow library.java.grpc_netty
   shadow library.java.netty_transport_native_epoll
+  provided library.java.junit
 
 Review comment:
   testCompile only applies to the test source set.
   provided applies to the main source set, there are some test utility classes in the main
source set that rely on junit classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 111533)
    Time Spent: 40m  (was: 0.5h)

> Hamcrest and JUnit are being leaked into the main path (should be test only)
> ----------------------------------------------------------------------------
>
>                 Key: BEAM-4540
>                 URL: https://issues.apache.org/jira/browse/BEAM-4540
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Ismaël Mejía
>            Assignee: Luke Cwik
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> The sdks/java/io/google-cloud-platform module includes Hamcrest and JUnit as a test dependency
via shadowTest. However it seems both dependencies can be resolved from the the main java
path (src/main/java).
> I discovered this while checking at BEAM-4539. We should probably validate the isolation
level of shadowTest so deps don't leak to the main path otherwise developers will start to
use them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message