beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4533) Beam SQL should support unquoted types
Date Tue, 12 Jun 2018 17:01:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4533?focusedWorklogId=111134&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111134
]

ASF GitHub Bot logged work on BEAM-4533:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Jun/18 17:00
            Start Date: 12/Jun/18 17:00
    Worklog Time Spent: 10m 
      Work Description: XuMingmin commented on a change in pull request #5601: [BEAM-4533]
[SQL] Support unquoted table types
URL: https://github.com/apache/beam/pull/5601#discussion_r194816087
 
 

 ##########
 File path: sdks/java/extensions/sql/src/main/codegen/includes/parserImpls.ftl
 ##########
 @@ -160,7 +160,12 @@ SqlCreate SqlCreateTable(Span s, boolean replace) :
     <TABLE> ifNotExists = IfNotExistsOpt()
     id = CompoundIdentifier()
     fieldList = FieldListParens()
-    <TYPE> type = StringLiteral()
+    <TYPE>
+    (
+        type = StringLiteral()
+    |
+        type = SimpleIdentifier()
 
 Review comment:
   Right, `StringLiteral` is still the syntax for most cases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 111134)
    Time Spent: 1.5h  (was: 1h 20m)

> Beam SQL should support unquoted types
> --------------------------------------
>
>                 Key: BEAM-4533
>                 URL: https://issues.apache.org/jira/browse/BEAM-4533
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> TYPE text in addition to TYPE 'text'



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message