beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4495) Create website pre-commits for apache/beam repository
Date Fri, 29 Jun 2018 18:07:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4495?focusedWorklogId=117517&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-117517
]

ASF GitHub Bot logged work on BEAM-4495:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Jun/18 18:06
            Start Date: 29/Jun/18 18:06
    Worklog Time Spent: 10m 
      Work Description: udim commented on a change in pull request #5809: [BEAM-4495] Add
Gradle tasks for website and add Jenkins pre-commit job
URL: https://github.com/apache/beam/pull/5809#discussion_r199238770
 
 

 ##########
 File path: website/build.gradle
 ##########
 @@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+// Define common lifecycle tasks and artifact types
+apply plugin: "base"
+
+task cleanWebsite(type: Delete) {
+  delete '.sass-cache', '.testcontent', 'content'
+}
+clean.dependsOn cleanWebsite
+
+task installBundler(type: Exec) {
+  commandLine './install_bundler.sh'
 
 Review comment:
   Perhaps `commandLine` is a special case, but I believe the way you wrote the tasks in this
file makes them execute during Gradle's configuration phase (regardless of the task chosen
to be executed). I would put the commands in these tasks within a `doLast` closure.
   
   Here's an example from the documentation:
   ```
   task testBoth {
       doFirst {
         println 'This is executed first during the execution phase.'
       }
       doLast {
         println 'This is executed last during the execution phase.'
       }
       println 'This is executed during the configuration phase as well.'
   }
   ```
   https://docs.gradle.org/current/userguide/build_lifecycle.html

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 117517)
    Time Spent: 2h 10m  (was: 2h)

> Create website pre-commits for apache/beam repository
> -----------------------------------------------------
>
>                 Key: BEAM-4495
>                 URL: https://issues.apache.org/jira/browse/BEAM-4495
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing, website
>            Reporter: Scott Wegner
>            Assignee: Scott Wegner
>            Priority: Major
>              Labels: beam-site-automation-reliability
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message