beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4399) Change CassandraIOIT to write-then-read Performance Tests
Date Thu, 14 Jun 2018 13:35:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4399?focusedWorklogId=111872&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-111872
]

ASF GitHub Bot logged work on BEAM-4399:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/18 13:34
            Start Date: 14/Jun/18 13:34
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on a change in pull request #5632: [BEAM-4399] Change
CassandraIOIT to write-then-read
URL: https://github.com/apache/beam/pull/5632#discussion_r195424568
 
 

 ##########
 File path: sdks/java/io/cassandra/src/test/java/org/apache/beam/sdk/io/cassandra/CassandraIOIT.java
 ##########
 @@ -70,159 +65,166 @@
 @RunWith(JUnit4.class)
 public class CassandraIOIT implements Serializable {
 
-  private static IOTestPipelineOptions options;
+  /** CassandraIOIT options. */
+  public interface CassandraIOITOptions extends IOTestPipelineOptions {
+    /* Cassandra */
+    @org.apache.beam.sdk.options.Description("Host for Cassandra server (host name/ip address)")
+    List<String> getCassandraHost();
 
 Review comment:
   makes sense so adding it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 111872)
    Time Spent: 2h 50m  (was: 2h 40m)

> Change CassandraIOIT to write-then-read Performance Tests
> ---------------------------------------------------------
>
>                 Key: BEAM-4399
>                 URL: https://issues.apache.org/jira/browse/BEAM-4399
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Łukasz Gajowy
>            Assignee: Ismaël Mejía
>            Priority: Minor
>          Time Spent: 2h 50m
>  Remaining Estimate: 0h
>
> CassandraIOIT is different than other IOITs (such as JdbcIOIT or MongodbIOIT) and does
not fulfil the rules described in the documentation: [https://beam.apache.org/documentation/io/testing/#i-o-transform-integration-tests]. 
> We should make it coherent with other tests, more specifically: 
>  - write it in writeThenReadAll style
>  - enable running it with Perfkit
>  - provide Jenkins job to run it periodically



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message