beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4333) Add integration tests for mobile game examples
Date Sat, 23 Jun 2018 02:57:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4333?focusedWorklogId=115014&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-115014
]

ASF GitHub Bot logged work on BEAM-4333:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Jun/18 02:56
            Start Date: 23/Jun/18 02:56
    Worklog Time Spent: 10m 
      Work Description: mariapython commented on a change in pull request #5747: [BEAM-4333]
Add integration tests for python mobile games
URL: https://github.com/apache/beam/pull/5747#discussion_r197600369
 
 

 ##########
 File path: sdks/python/apache_beam/examples/complete/game/game_stats.py
 ##########
 @@ -230,7 +229,7 @@ def expand(self, user_scores):
 class UserSessionActivity(beam.DoFn):
   """Calculate and output an element's session duration, in seconds."""
   def process(self, elem, window=beam.DoFn.WindowParam):
-    yield (window.end.micros - window.start.micros)//1000000
+    yield (window.end.micros - window.start.micros) / 1000000
 
 Review comment:
   This is something that pycodestyle corrected. I'll put it back.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 115014)
    Time Spent: 3h 20m  (was: 3h 10m)

> Add integration tests for mobile game examples
> ----------------------------------------------
>
>                 Key: BEAM-4333
>                 URL: https://issues.apache.org/jira/browse/BEAM-4333
>             Project: Beam
>          Issue Type: New Feature
>          Components: sdk-py-core
>            Reporter: María GH
>            Assignee: María GH
>            Priority: Minor
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Add integration tests for the 4 [mobile game examples|https://github.com/apache/beam/tree/master/sdks/python/apache_beam/examples/complete/game].
> Setup a Jenkins test to run the above integration tests at a daily frequency.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message