beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4325) Enforce ErrorProne analysis in the SQL project
Date Tue, 19 Jun 2018 01:03:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4325?focusedWorklogId=112967&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112967
]

ASF GitHub Bot logged work on BEAM-4325:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Jun/18 01:02
            Start Date: 19/Jun/18 01:02
    Worklog Time Spent: 10m 
      Work Description: cademarkegard commented on a change in pull request #5669: [BEAM-4325]
Enforce ErrorProne analysis in the SQL project
URL: https://github.com/apache/beam/pull/5669#discussion_r196268848
 
 

 ##########
 File path: build_rules.gradle
 ##########
 @@ -418,7 +418,7 @@ ext.applyJavaNature = {
   targetCompatibility = configuration.javaVersion
   tasks.withType(JavaCompile) {
     options.encoding = "UTF-8"
-    options.compilerArgs += ["-Xlint:all","-Xlint:-options","-Xlint:-cast","-Xlint:-deprecation","-Xlint:-processing","-Xlint:-rawtypes","-Xlint:-serial","-Xlint:-try","-Xlint:-unchecked","-Xlint:-varargs","-parameters"]
+    options.compilerArgs += ["-Xlint:all","-Xlint:-options","-Xlint:-cast","-Xlint:-deprecation","-Xlint:-dep-ann","-Xlint:-processing","-Xlint:-rawtypes","-Xlint:-serial","-Xlint:-try","-Xlint:-unchecked","-Xlint:-varargs","-parameters"]
 
 Review comment:
   Unfortunately there is a missing `@Deprecated` in the code generated via javacc. We are
dependent on javacc 4.0, not sure the reasoning, nor do I know if upgrading would fix this
issue and not cause others.
   
   I'm honestly not really a fan of this solution either since it blankets the rest of the
project. With the assumption that we keep javacc locked down, we could expand the `applyJavaNature`
to have a param to enable this flag explicitly. Thoughts?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 112967)
    Time Spent: 50m  (was: 40m)

> Enforce ErrorProne analysis in the SQL project
> ----------------------------------------------
>
>                 Key: BEAM-4325
>                 URL: https://issues.apache.org/jira/browse/BEAM-4325
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Scott Wegner
>            Assignee: Cade Markegard
>            Priority: Minor
>              Labels: errorprone, starter
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161]
in the Gradle build process, but only as warnings. ErrorProne errors are generally useful
and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319]
and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-extensions-sql}}.
Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/]
to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew
:beam-sdks-java-extensions-sql:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/extensions/sql}} project.
> # In {{sdks/java/extensions/sql/build.gradle}}, add {{failOnWarning: true}} to the call
the {{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/]
with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message