beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-4325) Enforce ErrorProne analysis in the SQL project
Date Tue, 19 Jun 2018 00:08:00 GMT


ASF GitHub Bot logged work on BEAM-4325:

                Author: ASF GitHub Bot
            Created on: 19/Jun/18 00:07
            Start Date: 19/Jun/18 00:07
    Worklog Time Spent: 10m 
      Work Description: swegner commented on a change in pull request #5669: [BEAM-4325] Enforce
ErrorProne analysis in the SQL project

 File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/interpreter/operator/
 @@ -51,8 +51,8 @@ public SqlTypeName opType(int idx) {
   public <T> T opValueEvaluated(
-      int idx, Row row, BoundedWindow window, BeamSqlExpressionEnvironment env) {
-    return (T) op(idx).evaluate(row, window, env).getValue();
+      Class<T> clazz, int idx, Row row, BoundedWindow window, BeamSqlExpressionEnvironment
env) {
 Review comment:
   I'm not a fan of this solution; it still seems like a misuse of the type system. In other
places, I've removed the type parameter and returned an `Object` and let the callee cast it.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 112957)
    Time Spent: 40m  (was: 0.5h)

> Enforce ErrorProne analysis in the SQL project
> ----------------------------------------------
>                 Key: BEAM-4325
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Scott Wegner
>            Assignee: Cade Markegard
>            Priority: Minor
>              Labels: errorprone, starter
>          Time Spent: 40m
>  Remaining Estimate: 0h
> Java ErrorProne static analysis was [recently enabled|]
in the Gradle build process, but only as warnings. ErrorProne errors are generally useful
and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|]
and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-extensions-sql}}.
Additional context discussed on the [dev list|].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|]
to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew
> # Fix each ErrorProne warning from the {{sdks/java/extensions/sql}} project.
> # In {{sdks/java/extensions/sql/build.gradle}}, add {{failOnWarning: true}} to the call
the {{applyJavaNature()}} ([example|]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|]
with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|]
> * Slack: [@Scott Wegner|]
> * Email: swegner at google dot com

This message was sent by Atlassian JIRA

View raw message