beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4276) Implement the portable lifted Combiner transforms in Go SDK
Date Mon, 04 Jun 2018 23:34:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4276?focusedWorklogId=108813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108813
]

ASF GitHub Bot logged work on BEAM-4276:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/18 23:33
            Start Date: 04/Jun/18 23:33
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on a change in pull request #5507: [BEAM-4276]
Add combiner lifting support to Go SDK
URL: https://github.com/apache/beam/pull/5507#discussion_r192909642
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/exec/combine_test.go
 ##########
 @@ -148,7 +96,14 @@ func getCombineEdge(t *testing.T, cfn interface{}, ac *coder.Coder) *graph.Multi
 	}
 
 	g := graph.New()
-	inT := typex.NewCoGBK(typex.New(reflectx.Int), typex.New(reflectx.Int))
+	var vtype reflect.Type
+	if fn.AddInputFn() != nil {
+		// This makes the assumption that the AddInput function is unkeyed.
 
 Review comment:
   As in it's unimplemented since it's a helper for a test, and none of the test cases exercise
that at present. As implemented the CreateAccumulator and the AddInput functions are permitted
to take a key as input.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 108813)
    Time Spent: 6h 10m  (was: 6h)

> Implement the portable lifted Combiner transforms in Go SDK
> -----------------------------------------------------------
>
>                 Key: BEAM-4276
>                 URL: https://issues.apache.org/jira/browse/BEAM-4276
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Robert Burke
>            Priority: Major
>          Time Spent: 6h 10m
>  Remaining Estimate: 0h
>
> Specifically add the necessary code to produce a Combine Composite with the correct URN,
and permit the SDK harness to understand the lifted parts when receiving a bundle plan from
the worker.
> Not expected as part of this issue is:
> Additional performance tweaks to the in memory cache (SeeĀ [BEAM-4468|https://issues.apache.org/jira/browse/BEAM-4468])



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message