beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3998) Futurize and fix python 2 compatibility for examples subpackage
Date Sat, 16 Jun 2018 00:32:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3998?focusedWorklogId=112492&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-112492
]

ASF GitHub Bot logged work on BEAM-3998:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jun/18 00:31
            Start Date: 16/Jun/18 00:31
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5652: [BEAM-3998]
Futurize examples subpackage
URL: https://github.com/apache/beam/pull/5652#discussion_r195887675
 
 

 ##########
 File path: sdks/python/apache_beam/examples/snippets/snippets.py
 ##########
 @@ -1048,7 +1055,7 @@ def to_entity(content):
     entity = entity_pb2.Entity()
     googledatastore.helper.add_key_path(entity.key, kind, str(uuid.uuid4()))
     googledatastore.helper.add_properties(entity,
-                                          {'content': six.text_type(content)})
+                                          {'content': unicode(content)})
 
 Review comment:
   Several other modules in the `examples` package also use six, let's clean them up. 
   See: https://github.com/apache/beam/search?q=six.text_type&unscoped_q=six.text_type.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 112492)
    Time Spent: 0.5h  (was: 20m)

> Futurize and fix python 2 compatibility for examples subpackage
> ---------------------------------------------------------------
>
>                 Key: BEAM-3998
>                 URL: https://issues.apache.org/jira/browse/BEAM-3998
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Matthias Feys
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message