beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3926) Support MetricsPusher in Dataflow Runner
Date Mon, 04 Jun 2018 22:44:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3926?focusedWorklogId=108799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-108799
]

ASF GitHub Bot logged work on BEAM-3926:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Jun/18 22:43
            Start Date: 04/Jun/18 22:43
    Worklog Time Spent: 10m 
      Work Description: ajamato commented on issue #5437: [BEAM-3926] Add new metrics protos
based on "Defining and adding SDK Metrics" htt…
URL: https://github.com/apache/beam/pull/5437#issuecomment-394523899
 
 
   test this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 108799)
    Time Spent: 5h 20m  (was: 5h 10m)

> Support MetricsPusher in Dataflow Runner
> ----------------------------------------
>
>                 Key: BEAM-3926
>                 URL: https://issues.apache.org/jira/browse/BEAM-3926
>             Project: Beam
>          Issue Type: Sub-task
>          Components: runner-dataflow
>            Reporter: Scott Wegner
>            Assignee: Pablo Estrada
>            Priority: Major
>          Time Spent: 5h 20m
>  Remaining Estimate: 0h
>
> See [relevant email thread|https://lists.apache.org/thread.html/2e87f0adcdf8d42317765f298e3e6fdba72917a72d4a12e71e67e4b5@%3Cdev.beam.apache.org%3E].
From [~echauchot]:
>   
> _AFAIK Dataflow being a cloud hosted engine, the related runner is very different from
the others. It just submits a job to the cloud hosted engine. So, no access to metrics container
etc... from the runner. So I think that the MetricsPusher (component responsible for merging
metrics and pushing them to a sink backend) must not be instanciated in DataflowRunner otherwise
it would be more a client (driver) piece of code and we will lose all the interest of being
close to the execution engine (among other things instrumentation of the execution of the
pipelines).  I think that the MetricsPusher needs to be instanciated in the actual Dataflow
engine._
>  
>   



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message