beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3708) Implement the portable lifted Combiner transforms in Java SDK
Date Wed, 20 Jun 2018 23:25:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3708?focusedWorklogId=113970&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-113970
]

ASF GitHub Bot logged work on BEAM-3708:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 20/Jun/18 23:24
            Start Date: 20/Jun/18 23:24
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5622: [BEAM-3708]
Adding Combine component implementations to Java SDK
URL: https://github.com/apache/beam/pull/5622#discussion_r196966761
 
 

 ##########
 File path: sdks/java/harness/src/main/java/org/apache/beam/fn/harness/CombineRunners.java
 ##########
 @@ -0,0 +1,126 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.fn.harness;
+
+import com.google.auto.service.AutoService;
+import com.google.common.collect.ImmutableMap;
+import java.io.IOException;
+import java.util.Map;
+import org.apache.beam.model.pipeline.v1.RunnerApi.CombinePayload;
+import org.apache.beam.model.pipeline.v1.RunnerApi.PTransform;
+import org.apache.beam.model.pipeline.v1.RunnerApi.StandardPTransforms;
+import org.apache.beam.runners.core.construction.BeamUrns;
+import org.apache.beam.sdk.fn.function.ThrowingFunction;
+import org.apache.beam.sdk.transforms.Combine.CombineFn;
+import org.apache.beam.sdk.util.SerializableUtils;
+import org.apache.beam.sdk.values.KV;
+
+/**
+ * Executes different components of Combine PTransforms.
+ */
+public class CombineRunners<InputT, OutputT> {
+
+  private static final String PRECOMBINE_URN =
 
 Review comment:
   Not much value in declaring these constants here again since they are used in this class
only once so directly reference them there.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 113970)

> Implement the portable lifted Combiner transforms in Java SDK
> -------------------------------------------------------------
>
>                 Key: BEAM-3708
>                 URL: https://issues.apache.org/jira/browse/BEAM-3708
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-core, sdk-java-harness
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: Major
>              Labels: portability
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Lifted combines are split into separate parts with different URNs. These parts need
to be implemented in the Java SDK harness so that the SDK can actually execute them when
receiving Combine transforms with the corresponding URNs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message