beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3446) RedisIO non-prefix read operations
Date Thu, 28 Jun 2018 16:27:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3446?focusedWorklogId=116882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-116882
]

ASF GitHub Bot logged work on BEAM-3446:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Jun/18 16:26
            Start Date: 28/Jun/18 16:26
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on issue #4656: [BEAM-3446] Fixes RedisIO non-prefix
read operations 
URL: https://github.com/apache/beam/pull/4656#issuecomment-401093881
 
 
   We have turned on autoformatting of the codebase, which causes small conflicts across the
board. You can probably safely rebase and just keep your changes. Like this:
   
   ```
   $ git rebase
   ... see some conflicts
   $ git diff
   ... confirmed that the conflicts are just autoformatting
   ... so we can just keep our changes are do our own autoformat
   $ git checkout --theirs --
   $ git add -u
   $ git rebase --continue
   $ ./gradlew spotlessJavaApply
   ```
   
   Please ping me if you run into any difficulty. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 116882)
    Time Spent: 40m  (was: 0.5h)

> RedisIO non-prefix read operations
> ----------------------------------
>
>                 Key: BEAM-3446
>                 URL: https://issues.apache.org/jira/browse/BEAM-3446
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-redis
>            Reporter: Vinay varma
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Read operation in RedisIO is for prefix based look ups. While this can be used for exact
key matches as well, the number of operations limits the through put of the function.
> I suggest exposing current readAll operation as readbyprefix and using more simpler operations
for readAll functionality.
> ex:
> {code:java}
> String output = jedis.get(element);
> if (output != null) {
>     processContext.output(KV.of(element, output));
> }
> {code}
> instead of:
> https://github.com/apache/beam/blob/7d240c0bb171af6868f1a6e95196c9dcfc9ac640/sdks/java/io/redis/src/main/java/org/apache/beam/sdk/io/redis/RedisIO.java#L292



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message