beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3310) Push metrics to a backend in an runner agnostic way
Date Thu, 14 Jun 2018 23:22:00 GMT


ASF GitHub Bot logged work on BEAM-3310:

                Author: ASF GitHub Bot
            Created on: 14/Jun/18 23:20
            Start Date: 14/Jun/18 23:20
    Worklog Time Spent: 10m 
      Work Description: zorro786 commented on a change in pull request #4548: [BEAM-3310]
Metrics pusher

 File path: runners/flink/src/main/java/org/apache/beam/runners/flink/
 @@ -120,7 +121,9 @@ public PipelineResult run(Pipeline pipeline) {
     if (result instanceof DetachedEnvironment.DetachedJobExecutionResult) {"Pipeline submitted in Detached mode");
-      return new FlinkDetachedRunnerResult();
+      FlinkDetachedRunnerResult flinkDetachedRunnerResult = new FlinkDetachedRunnerResult();
+      // no metricsPusher because metrics are not supported in detached mode
 Review comment:
   @echauchot Does this mean that any metrics created with `Metrics.counter(), Metrics.gauge()`
etc. methods in classes extending `DoFn` won't be visible/computed if the pipeline executes
in detached mode?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 112102)
    Time Spent: 12h 40m  (was: 12.5h)

> Push metrics to a backend in an runner agnostic way
> ---------------------------------------------------
>                 Key: BEAM-3310
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-extensions-metrics, sdk-java-core
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>            Priority: Major
>          Time Spent: 12h 40m
>  Remaining Estimate: 0h
> The idea is to avoid relying on the runners to provide access to the metrics (either
at the end of the pipeline or while it runs) because they don't have all the same capabilities
towards metrics (e.g. spark runner configures sinks  like csv, graphite or in memory sinks
using the spark engine conf). The target is to push the metrics in the common runner code
so that no matter the chosen runner, a user can get his metrics out of beam.
> Here is the link to the discussion thread on the dev ML:
> And the design doc:

This message was sent by Atlassian JIRA

View raw message