From commits-return-73885-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue May 22 19:05:06 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 048DE180638 for ; Tue, 22 May 2018 19:05:05 +0200 (CEST) Received: (qmail 54173 invoked by uid 500); 22 May 2018 17:05:05 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 54164 invoked by uid 99); 22 May 2018 17:05:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 22 May 2018 17:05:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 88649C0010 for ; Tue, 22 May 2018 17:05:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id v1ofaePZi5Jm for ; Tue, 22 May 2018 17:05:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id BF57E5F23C for ; Tue, 22 May 2018 17:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 56F73E00FC for ; Tue, 22 May 2018 17:05:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 19417217C3 for ; Tue, 22 May 2018 17:05:00 +0000 (UTC) Date: Tue, 22 May 2018 17:05:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=3D1= 04689&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpan= el#worklog-104689 ] ASF GitHub Bot logged work on BEAM-4375: ---------------------------------------- Author: ASF GitHub Bot Created on: 22/May/18 17:04 Start Date: 22/May/18 17:04 Worklog Time Spent: 10m=20 Work Description: swegner commented on issue #5440: [BEAM-4375] Repla= ces usage of JUnit runners that do not work well with Gradle URL: https://github.com/apache/beam/pull/5440#issuecomment-391066956 =20 =20 Thanks for this. I can see from the [Gradle build scan](https://scans.gr= adle.com/s/zehazergdsv7q) that tests such as `=09ParDoTest$TimerTests` are = now being run. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 104689) Time Spent: 1.5h (was: 1h 20m) > Gradle doesn't run tests under RunWith(Enclosed.class) > ------------------------------------------------------ > > Key: BEAM-4375 > URL: https://issues.apache.org/jira/browse/BEAM-4375 > Project: Beam > Issue Type: Bug > Components: build-system > Reporter: Eugene Kirpichov > Assignee: Scott Wegner > Priority: Blocker > Time Spent: 1.5h > Remaining Estimate: 0h > > If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look= at the produced test report, one can see that it is missing tests that hav= e RunWith(Enclosed.class), e.g. ParDoTest, CombineTest, MetricsTest etc. > =C2=A0 > This is very very bad - some of these tests are already known to be (sile= ntly) broken. > =C2=A0 > Likely [https://github.com/gradle/gradle/issues/2985]=C2=A0. As an emerge= ncy measure, let's convert to top-level classes. -- This message was sent by Atlassian JIRA (v7.6.3#76005)