From commits-return-73274-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri May 18 07:46:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id BBCCE180648 for ; Fri, 18 May 2018 07:46:04 +0200 (CEST) Received: (qmail 46926 invoked by uid 500); 18 May 2018 05:46:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 46909 invoked by uid 99); 18 May 2018 05:46:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 May 2018 05:46:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0AFA3C0033 for ; Fri, 18 May 2018 05:46:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id sDOV4_B2JJNV for ; Fri, 18 May 2018 05:46:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9C9215FC5D for ; Fri, 18 May 2018 05:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 017DBE0D0F for ; Fri, 18 May 2018 05:46:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 47BC8217A9 for ; Fri, 18 May 2018 05:46:00 +0000 (UTC) Date: Fri, 18 May 2018 05:46:00 +0000 (UTC) From: "Tim Robertson (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (BEAM-4353) Enforce ErrorProne analysis in the solr IO project MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tim Robertson reassigned BEAM-4353: ----------------------------------- Assignee: Tim Robertson > Enforce ErrorProne analysis in the solr IO project > -------------------------------------------------- > > Key: BEAM-4353 > URL: https://issues.apache.org/jira/browse/BEAM-4353 > Project: Beam > Issue Type: Improvement > Components: io-java-solr > Reporter: Scott Wegner > Assignee: Tim Robertson > Priority: Minor > Labels: errorprone, starter > > Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161] in the Gradle build process, but only as warnings. ErrorProne errors are generally useful and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319] and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-io-solr}}. Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E]. > Fixing this issue will involve: > # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/] to set up a {{beam}} development environment. > # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew :beam-sdks-java-io-solr:assemble}} > # Fix each ErrorProne warning from the {{sdks/java/io/solr}} project. > # In {{sdks/java/io/solr/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]). > This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/] with questions or code review: > * JIRA: [~swegner] > * GitHub: [@swegner|https://github.com/swegner] > * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel] > * Email: swegner at google dot com -- This message was sent by Atlassian JIRA (v7.6.3#76005)