beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4375) Gradle doesn't run tests under RunWith(Enclosed.class)
Date Tue, 22 May 2018 17:05:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4375?focusedWorklogId=104689&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104689
]

ASF GitHub Bot logged work on BEAM-4375:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/May/18 17:04
            Start Date: 22/May/18 17:04
    Worklog Time Spent: 10m 
      Work Description: swegner commented on issue #5440: [BEAM-4375] Replaces usage of JUnit
runners that do not work well with Gradle
URL: https://github.com/apache/beam/pull/5440#issuecomment-391066956
 
 
   Thanks for this. I can see from the [Gradle build scan](https://scans.gradle.com/s/zehazergdsv7q)
that tests such as `	ParDoTest$TimerTests` are now being run.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 104689)
    Time Spent: 1.5h  (was: 1h 20m)

> Gradle doesn't run tests under RunWith(Enclosed.class)
> ------------------------------------------------------
>
>                 Key: BEAM-4375
>                 URL: https://issues.apache.org/jira/browse/BEAM-4375
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Eugene Kirpichov
>            Assignee: Scott Wegner
>            Priority: Blocker
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> If you run ./gradlew :beam-runners-direct-java:needsRunnerTests, and look at the produced
test report, one can see that it is missing tests that have RunWith(Enclosed.class), e.g.
ParDoTest, CombineTest, MetricsTest etc.
>  
> This is very very bad - some of these tests are already known to be (silently) broken.
>  
> Likely [https://github.com/gradle/gradle/issues/2985] . As an emergency measure, let's
convert to top-level classes.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message