beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4356) Enforce ErrorProne analysis in the nexmark project
Date Thu, 31 May 2018 07:45:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4356?focusedWorklogId=107592&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107592
]

ASF GitHub Bot logged work on BEAM-4356:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/18 07:44
            Start Date: 31/May/18 07:44
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on a change in pull request #5513: [BEAM-4356] Enforce
ErrorProne analysis in nexmark
URL: https://github.com/apache/beam/pull/5513#discussion_r192013297
 
 

 ##########
 File path: sdks/java/nexmark/src/main/java/org/apache/beam/sdk/nexmark/NexmarkSuite.java
 ##########
 @@ -25,6 +25,7 @@
 /**
  * A set of {@link NexmarkConfiguration}s.
  */
+@SuppressWarnings("ImmutableEnumChecker")
 
 Review comment:
   I agree that the idea of fixing errorprone issues is not to just mark things to be ignored,
but here there is a bigger issue.  This change is not so simple, at the first try I just changed
the Lists to be immutable, but errorprone requires the type of the object in the list [to
be immutable too](http://errorprone.info/bugpattern/ImmutableEnumChecker).
   
   So fixing this implies making `NexmarkConfiguration` an Immutable object and this has a
considerable impact so I prefer that this is covered in a different ticket (also to address
the repeated options with NexmarkOptions). I just created [BEAM-4433](https://issues.apache.org/jira/browse/BEAM-4433)
for this. Feel free to take it @cademarkegard if you are interested on working on it.
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 107592)
    Time Spent: 50m  (was: 40m)

> Enforce ErrorProne analysis in the nexmark project
> --------------------------------------------------
>
>                 Key: BEAM-4356
>                 URL: https://issues.apache.org/jira/browse/BEAM-4356
>             Project: Beam
>          Issue Type: Improvement
>          Components: examples-nexmark
>            Reporter: Scott Wegner
>            Assignee: Ismaël Mejía
>            Priority: Minor
>              Labels: errorprone, starter
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161]
in the Gradle build process, but only as warnings. ErrorProne errors are generally useful
and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319]
and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-nexmark}}.
Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/]
to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew
:beam-sdks-java-nexmark:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/nexmark}} project.
> # In {{sdks/java/nexmark/build.gradle}}, add {{failOnWarning: true}} to the call the
{{applyJavaNature()}} ([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/]
with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message