beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4346) Enforce ErrorProne analysis in the jms IO project
Date Fri, 18 May 2018 14:28:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4346?focusedWorklogId=103389&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-103389
]

ASF GitHub Bot logged work on BEAM-4346:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 18/May/18 14:27
            Start Date: 18/May/18 14:27
    Worklog Time Spent: 10m 
      Work Description: timrobertson100 opened a new pull request #5423: [BEAM-4346] Enforce
ErrorProne analysis in JMS IO
URL: https://github.com/apache/beam/pull/5423
 
 
   Simple PR to enforce a build failure on error prone warnings, and addresses current warnings
   
   CC @iemejia for a review (super simple one)
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 103389)
            Time Spent: 10m
    Remaining Estimate: 0h

> Enforce ErrorProne analysis in the jms IO project
> -------------------------------------------------
>
>                 Key: BEAM-4346
>                 URL: https://issues.apache.org/jira/browse/BEAM-4346
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-jms
>            Reporter: Scott Wegner
>            Assignee: Tim Robertson
>            Priority: Minor
>              Labels: errorprone, starter
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161]
in the Gradle build process, but only as warnings. ErrorProne errors are generally useful
and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319]
and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{beam-sdks-java-io-jms}}.
Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/]
to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew
:beam-sdks-java-io-jms:assemble}}
> # Fix each ErrorProne warning from the {{sdks/java/io/jms}} project.
> # In {{sdks/java/io/jms/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}}
([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/]
with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message