beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4303) Enforce ErrorProne analysis in examples project
Date Thu, 31 May 2018 18:18:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4303?focusedWorklogId=107800&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-107800
]

ASF GitHub Bot logged work on BEAM-4303:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/May/18 18:17
            Start Date: 31/May/18 18:17
    Worklog Time Spent: 10m 
      Work Description: swegner commented on a change in pull request #5521: [BEAM-4303] Enforce
ErrorProne analysis in examples project
URL: https://github.com/apache/beam/pull/5521#discussion_r192191263
 
 

 ##########
 File path: examples/java/src/main/java/org/apache/beam/examples/cookbook/TriggerExample.java
 ##########
 @@ -393,12 +393,12 @@ public void processElement(ProcessContext c, BoundedWindow window)
throws Except
   static class ExtractFlowInfo extends DoFn<String, KV<String, Integer>> {
     @ProcessElement
     public void processElement(ProcessContext c) throws Exception {
-      String[] laneInfo = c.element().split(",");
+      String[] laneInfo = c.element().split(",", -1);
       if ("timestamp".equals(laneInfo[0])) {
         // Header row
         return;
       }
-      if (laneInfo.length < 48) {
+      if (laneInfo.length < 50) {
 
 Review comment:
   Can you elaborate on what this change is for? I'm not sure what this magic number represents.
If you are familiar, perhaps extract it out as a named constant that provides some context.
i.e. `const int NUM_FIELDS = 50;`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 107800)
    Time Spent: 1h  (was: 50m)

> Enforce ErrorProne analysis in examples project
> -----------------------------------------------
>
>                 Key: BEAM-4303
>                 URL: https://issues.apache.org/jira/browse/BEAM-4303
>             Project: Beam
>          Issue Type: Improvement
>          Components: examples-java
>            Reporter: Scott Wegner
>            Assignee: Cade Markegard
>            Priority: Minor
>              Labels: errorprone, starter
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Java ErrorProne static analysis was [recently enabled|https://github.com/apache/beam/pull/5161]
in the Gradle build process, but only as warnings. ErrorProne errors are generally useful
and easy to fix. Some work was done to [make sdks-java-core ErrorProne-clean|https://github.com/apache/beam/pull/5319]
and add enforcement. This task is clean ErrorProne warnings and add enforcement in {{examples-java}}.
Additional context discussed on the [dev list|https://lists.apache.org/thread.html/95aae2785c3cd728c2d3378cbdff2a7ba19caffcd4faa2049d2e2f46@%3Cdev.beam.apache.org%3E].
> Fixing this issue will involve:
> # Follow instructions in the [Contribution Guide|https://beam.apache.org/contribute/]
to set up a {{beam}} development environment.
> # Run the following command to compile and run ErrorProne analysis on the project: {{./gradlew
:beam-examples-java:assemble}}
> # Fix each ErrorProne warning from the {{examples/java}} project.
> # In {{examples/java/build.gradle}}, add {{failOnWarning: true}} to the call the {{applyJavaNature()}}
([example|https://github.com/apache/beam/pull/5319/files#diff-9390c20635aed5f42f83b97506a87333R20]).
> This starter issue is sponsored by [~swegner]. Feel free to [reach out|https://beam.apache.org/community/contact-us/]
with questions or code review:
> * JIRA: [~swegner]
> * GitHub: [@swegner|https://github.com/swegner]
> * Slack: [@Scott Wegner|https://s.apache.org/beam-slack-channel]
> * Email: swegner at google dot com



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message