beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4196) [SQL] Support Complex Types in DDL
Date Tue, 08 May 2018 12:31:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4196?focusedWorklogId=99487&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-99487
]

ASF GitHub Bot logged work on BEAM-4196:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/May/18 12:30
            Start Date: 08/May/18 12:30
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on a change in pull request #5276: [BEAM-4196][SQL]
Support complex types in DDL
URL: https://github.com/apache/beam/pull/5276#discussion_r186710134
 
 

 ##########
 File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/parser/BeamSqlParserTest.java
 ##########
 @@ -63,7 +64,7 @@ public void testParseCreateTable_withoutType() throws Exception {
     parseTable(
         "create table person (\n"
             + "id int COMMENT 'id', \n"
-            + "name varchar(31) COMMENT 'name') \n"
+            + "name varchar COMMENT 'name') \n"
 
 Review comment:
   <!--new_thread; commit:4a38a26e2bfa0631ef5426455a57802eb81e5e93; resolved:0-->
   OK, I commented on the CLI test, but this is the better place for the parser tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 99487)
    Time Spent: 2.5h  (was: 2h 20m)

> [SQL] Support Complex Types in DDL
> ----------------------------------
>
>                 Key: BEAM-4196
>                 URL: https://issues.apache.org/jira/browse/BEAM-4196
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Anton Kedin
>            Assignee: Anton Kedin
>            Priority: Major
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> Neither our DDL parser we copied from calcite-server or the calcite-server don't support
complex types in DDL. If we want to model something like JSON objects we need to support at
least Arrays and nested Rows.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message