beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4044) Take advantage of Calcite DDL
Date Thu, 10 May 2018 04:00:03 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4044?focusedWorklogId=100397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-100397
]

ASF GitHub Bot logged work on BEAM-4044:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/May/18 04:00
            Start Date: 10/May/18 04:00
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on a change in pull request #5325: [BEAM-4044]
[SQL] Just One Parser
URL: https://github.com/apache/beam/pull/5325#discussion_r187234601
 
 

 ##########
 File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/BeamSqlDslJoinTest.java
 ##########
 @@ -230,7 +224,9 @@ public void testRejectsUnboundedWithinWindowsWithEndOfWindowTrigger()
throws Exc
                    .accumulatingFiredPanes());
     PCollectionTuple inputs = tuple("ORDER_DETAILS1", orders, "ORDER_DETAILS2", orders);
 
-    thrown.expectCause(expectedSingleFireTrigger());
+    thrown.expect(UnsupportedOperationException.class);
+    thrown.expectMessage(
+        stringContainsInOrder(Arrays.asList("once per window", "default trigger")));
 
 Review comment:
   <!--new_thread; commit:a207bbffa47dfdd01562ef114379df669bf247bf; resolved:1-->
   I'm 50/50 on these. I do hold to the discipline that a test should not be factored or engineered,
but should be readable in isolation as pretty much straight line. At the same time, this one
seemed pretty benign. If it were written as a matcher it would probably pass muster.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 100397)
    Time Spent: 16h  (was: 15h 50m)

> Take advantage of Calcite DDL
> -----------------------------
>
>                 Key: BEAM-4044
>                 URL: https://issues.apache.org/jira/browse/BEAM-4044
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>          Time Spent: 16h
>  Remaining Estimate: 0h
>
> In Calcite 1.15 support for abstract DDL moved into calcite core. We should take advantage
of that.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message