beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3981) Futurize and fix python 2 compatibility for coders package
Date Wed, 02 May 2018 18:06:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3981?focusedWorklogId=97618&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-97618
]

ASF GitHub Bot logged work on BEAM-3981:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/18 18:05
            Start Date: 02/May/18 18:05
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on issue #5053: [BEAM-3981] Futurize coders subpackage
URL: https://github.com/apache/beam/pull/5053#issuecomment-386068489
 
 
   Based on the information I currently have, my best guess is that regression is caused by
changes in Cython's interpretation of Py3 implementations of range() and iteritems() in coder_impl.py.
We can see a difference in code generated by Cython here:
   
   https://docs.google.com/document/d/1S-oeqJGiMHt_L3iCgr9dYfQdR0_ukQE25mcvK-BqudU/edit#heading=h.xkt18qn9ofn1
   
   I am seeing 7% regression in the median on the benchmarks I've been running, and I was
able to see the regression go away with these changes reverted. 
   
   We can also try to benchmark these methods in isolation to confirm and rule out the variance
of test setup. I might not have time to do it this week.
   
   @robertwb , do you  think anything can be done to improve Cython translation here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 97618)
    Time Spent: 15.5h  (was: 15h 20m)

> Futurize and fix python 2 compatibility for coders package
> ----------------------------------------------------------
>
>                 Key: BEAM-3981
>                 URL: https://issues.apache.org/jira/browse/BEAM-3981
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Robbe
>            Assignee: Robbe
>            Priority: Major
>          Time Spent: 15.5h
>  Remaining Estimate: 0h
>
> Run automatic conversion with futurize tool on coders subpackage and fix python 2 compatibility.
This prepares the subpackage for python 3 support.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message