beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3883) Python SDK stages artifacts when talking to job server
Date Tue, 22 May 2018 17:22:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3883?focusedWorklogId=104703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-104703
]

ASF GitHub Bot logged work on BEAM-3883:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 22/May/18 17:21
            Start Date: 22/May/18 17:21
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #5273: [BEAM-3883]
Adding Client to push artifacts to artifact staging service
URL: https://github.com/apache/beam/pull/5273#discussion_r189931243
 
 

 ##########
 File path: sdks/python/apache_beam/runners/portability/portable_stager.py
 ##########
 @@ -0,0 +1,86 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+"""A :class:`FileHandler` to work with :class:`ArtifactStagingServiceStub`.
+"""
+
+from __future__ import absolute_import
+from __future__ import division
+from __future__ import print_function
+
+import os
+
+from apache_beam.portability.api import beam_artifact_api_pb2
+from apache_beam.portability.api import beam_artifact_api_pb2_grpc
+from apache_beam.runners.portability.stager import Stager
+
+
+class PortableStager(Stager):
+  """An implementation of :class:`Stager` to stage files on
+  ArtifactStagingService.
+
+  The class keeps track of pushed files and commit manifest once all files are
+  uploaded.
+
+  Note: This class is not thread safe and user of this class should ensure
+  thread safety.
+  """
+
+  def __init__(self, artifact_service_channel):
+    """Creates a new Stager to stage file to ArtifactStagingService.
+
+    Args:
+      artifact_service_channel: Channel used to interact with
+        ArtifactStagingService.User owns the channel and should close it when
+        finished.
+    """
+    super(PortableStager, self).__init__()
+    self._artifact_staging_stub = beam_artifact_api_pb2_grpc.\
+        ArtifactStagingServiceStub(channel=artifact_service_channel)
+    self._artifacts = []
+
+  def stage_artifact(self, local_path_to_artifact, artifact_name):
+    """Stage a file to ArtifactStagingService.
+
+    Args:
+      local_path_to_artifact: Path of file to be uploaded.
+      artifact_name: File name on the artifact server.
+    """
+    if not os.path.isfile(local_path_to_artifact):
+      raise ValueError('Can only stage file to artifact server. from_path: {0} '
 
 Review comment:
   Let's rewrite the message so that the root cause is emphasized. How about: `Cannot stage
{0} to artifact server. Only local files can be staged. `

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 104703)
    Time Spent: 17h 10m  (was: 17h)

> Python SDK stages artifacts when talking to job server
> ------------------------------------------------------
>
>                 Key: BEAM-3883
>                 URL: https://issues.apache.org/jira/browse/BEAM-3883
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: Ben Sidhom
>            Assignee: Ankur Goenka
>            Priority: Major
>          Time Spent: 17h 10m
>  Remaining Estimate: 0h
>
> The Python SDK does not currently stage its user-defined functions or dependencies when
talking to the job API. Artifacts that need to be staged include the user code itself, any
SDK components not included in the container image, and the list of Python packages that must
be installed at runtime.
>  
> Artifacts that are currently expected can be found in the harness boot code: [https://github.com/apache/beam/blob/58e3b06bee7378d2d8db1c8dd534b415864f63e1/sdks/python/container/boot.go#L52.]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message