beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3813) Support encryption for S3FileSystem (SSE-S3, SSE-C and SSE-KMS)
Date Tue, 29 May 2018 16:33:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3813?focusedWorklogId=106703&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-106703
]

ASF GitHub Bot logged work on BEAM-3813:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/May/18 16:32
            Start Date: 29/May/18 16:32
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5491: [BEAM-3813]
Support (de)serialization of S3 encryption options via JSON
URL: https://github.com/apache/beam/pull/5491#discussion_r191490827
 
 

 ##########
 File path: sdks/java/io/amazon-web-services/src/test/java/org/apache/beam/sdk/io/aws/options/S3ModuleTest.java
 ##########
 @@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.aws.options;
+
+import static org.hamcrest.Matchers.hasItem;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertThat;
+
+import com.amazonaws.services.s3.model.SSEAwsKeyManagementParams;
+import com.amazonaws.services.s3.model.SSECustomerKey;
+import com.fasterxml.jackson.databind.Module;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import java.util.List;
+import org.apache.beam.sdk.util.common.ReflectHelpers;
+import org.hamcrest.Matchers;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+/** Tests {@link S3Module}. */
+@RunWith(JUnit4.class)
+public class S3ModuleTest {
+  private final ObjectMapper objectMapper = new ObjectMapper().registerModule(new S3Module());
+
+  @Test
+  public void testObjectMapperIsAbleToFindModule() {
+    List<Module> modules = ObjectMapper.findModules(ReflectHelpers.findClassLoader());
+    assertThat(modules, hasItem(Matchers.instanceOf(S3Module.class)));
+  }
+
+  @Test
+  public void testSSECustomerKeySerializationDeserialization() throws Exception {
 
 Review comment:
   Try a test where you set the minimal set of properties.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 106703)
    Time Spent: 3h  (was: 2h 50m)

> Support encryption for S3FileSystem (SSE-S3, SSE-C and SSE-KMS)
> ---------------------------------------------------------------
>
>                 Key: BEAM-3813
>                 URL: https://issues.apache.org/jira/browse/BEAM-3813
>             Project: Beam
>          Issue Type: Improvement
>          Components: io-java-aws
>            Reporter: Ismaël Mejía
>            Assignee: Ismaël Mejía
>            Priority: Minor
>             Fix For: 2.5.0
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> We should enable AWS S3 users to use encryption when reading or writing by provide encryption
keys or using server side encryption via an algorithm, or a key management system (KMS)..
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message