beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3581) [SQL] Support for Non-ASCII chars is flaky
Date Wed, 16 May 2018 23:35:00 GMT


ASF GitHub Bot logged work on BEAM-3581:

                Author: ASF GitHub Bot
            Created on: 16/May/18 23:34
            Start Date: 16/May/18 23:34
    Worklog Time Spent: 10m 
      Work Description: apilloud opened a new pull request #5391: [BEAM-3581] [SQL] Use
for charset
   Hit the charset issues again for things that load calcite not via maven or gradle. This
should fix it once and for all by adding the config file to the jar.
   Follow this checklist to help us incorporate your contribution quickly and easily:
    - [X] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
    - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [X] Write a pull request description that is detailed enough to understand:
      - [X] What the pull request does
      - [X] Why it does it
      - [X] How it does it
      - [X] Why this approach
    - [X] Each commit in the pull request should have a meaningful subject line and body.
    - [X] Run `./gradlew build` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 102707)
    Time Spent: 1h  (was: 50m)

> [SQL] Support for Non-ASCII chars is flaky
> ------------------------------------------
>                 Key: BEAM-3581
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: dsl-sql
>            Reporter: Anton Kedin
>            Assignee: Anton Kedin
>            Priority: Major
>             Fix For: Not applicable
>          Time Spent: 1h
>  Remaining Estimate: 0h
> Beam SQL overrides default charset that Calcite uses and sets it to UTF16. It is done
via system properties.
> Problem is that we do this only when it hasn't been set yet. So if system property has
been set to ISO-8859-1 (Calcite's default), then test runs will fail when trying to encode
characters not supported in that encoding.
> Solution:
>  - because it's a system property, we don't want to force override it;
>  - for the same reason we cannot set it for a specific query execution;
>  - we can expose a static method on BeamSql to override these properties if explicitly
>  - affected tests will explicitly override it;
>  - otherwise behavior will stay unchanged and we will respect defaults and user settings;

This message was sent by Atlassian JIRA

View raw message