From commits-return-67365-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue Apr 17 23:43:10 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 31A1318078A for ; Tue, 17 Apr 2018 23:43:10 +0200 (CEST) Received: (qmail 42644 invoked by uid 500); 17 Apr 2018 21:43:06 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 42445 invoked by uid 99); 17 Apr 2018 21:43:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Apr 2018 21:43:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id A9F461A1A1E for ; Tue, 17 Apr 2018 21:43:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id q0XMbrig7PEn for ; Tue, 17 Apr 2018 21:43:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 847785FC13 for ; Tue, 17 Apr 2018 21:43:03 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E1DA2E0E92 for ; Tue, 17 Apr 2018 21:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DF181241EB for ; Tue, 17 Apr 2018 21:43:00 +0000 (UTC) Date: Tue, 17 Apr 2018 21:43:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-4071) Portable Runner Job API shim MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-4071?focusedWorklogId=3D9= 1941&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpane= l#worklog-91941 ] ASF GitHub Bot logged work on BEAM-4071: ---------------------------------------- Author: ASF GitHub Bot Created on: 17/Apr/18 21:42 Start Date: 17/Apr/18 21:42 Worklog Time Spent: 10m=20 Work Description: angoenka commented on a change in pull request #515= 0: [BEAM-4071] Add Portable Runner Job API shim URL: https://github.com/apache/beam/pull/5150#discussion_r182228332 =20 =20 ########## File path: runners/core-construction-java/src/main/java/org/apache/beam/ru= nners/core/construction/ArtifactServiceStager.java ########## @@ -87,26 +87,27 @@ private ArtifactServiceStager(Channel channel, int buf= ferSize) { this.bufferSize =3D bufferSize; } =20 - public void stage(Iterable files) throws IOException, InterruptedE= xception { - final Map> futures =3D new Has= hMap<>(); - for (File file : files) { + public String stage(Iterable files) throws IOException, Int= erruptedException { + final Map> futures =3D = new HashMap<>(); + for (FileToStage file : files) { futures.put(file, MoreFutures.supplyAsync(new StagingCallable(file),= executorService)); } CompletionStage stagingResult =3D MoreFutures.allAsList(futures.values()) .thenApply(ignored -> new ExtractStagingResultsCallable(future= s).call()); - stageManifest(stagingResult); + return stageManifest(stagingResult); } =20 - private void stageManifest(CompletionStage stagingFuture) + private String stageManifest(CompletionStage stagingFutur= e) throws InterruptedException { try { StagingResult stagingResult =3D MoreFutures.get(stagingFuture); =20 Review comment: Should we have a timeout for staging? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 91941) Time Spent: 4.5h (was: 4h 20m) > Portable Runner Job API shim > ---------------------------- > > Key: BEAM-4071 > URL: https://issues.apache.org/jira/browse/BEAM-4071 > Project: Beam > Issue Type: New Feature > Components: runner-core > Reporter: Ben Sidhom > Assignee: Ben Sidhom > Priority: Minor > Time Spent: 4.5h > Remaining Estimate: 0h > > There=C2=A0needs to=C2=A0be a way to execute Java-SDK pipelines against a= portable job server. The job server itself is expected to be started up ou= t-of-band. The "PortableRunner" should take an option indicating the Job AP= I endpoint and defer other runner configurations to the backend itself. -- This message was sent by Atlassian JIRA (v7.6.3#76005)