From commits-return-64747-archive-asf-public=cust-asf.ponee.io@beam.apache.org Wed Apr 4 20:18:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 1EF9A180675 for ; Wed, 4 Apr 2018 20:18:04 +0200 (CEST) Received: (qmail 94239 invoked by uid 500); 4 Apr 2018 18:18:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 94219 invoked by uid 99); 4 Apr 2018 18:18:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Apr 2018 18:18:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 7B07A1A0A07 for ; Wed, 4 Apr 2018 18:18:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id ypl3H-UKJaZq for ; Wed, 4 Apr 2018 18:18:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9BEDE5F5DD for ; Wed, 4 Apr 2018 18:18:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B6E94E02AC for ; Wed, 4 Apr 2018 18:18:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7018125617 for ; Wed, 4 Apr 2018 18:18:00 +0000 (UTC) Date: Wed, 4 Apr 2018 18:18:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-3437) Support schema in PCollections MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3437?focusedWorklogId=3D8= 7701&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpane= l#worklog-87701 ] ASF GitHub Bot logged work on BEAM-3437: ---------------------------------------- Author: ASF GitHub Bot Created on: 04/Apr/18 18:17 Start Date: 04/Apr/18 18:17 Worklog Time Spent: 10m=20 Work Description: reuvenlax commented on a change in pull request #49= 64: [BEAM-3437] Introduce Schema class, and use it in BeamSQL URL: https://github.com/apache/beam/pull/4964#discussion_r179236211 =20 =20 ########## File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/exte= nsions/sql/impl/parser/BeamSqlParserTest.java ########## @@ -163,13 +164,13 @@ private static Table mockTable(String name, String t= ype, String comment, JSONObj .columns(ImmutableList.of( Column.builder() .name("id") - .coder(INTEGER) + .typeDescriptor(TypeName.INT32.type()) .primaryKey(false) .comment("id") .build(), Column.builder() .name("name") - .coder(VARCHAR) + .typeDescriptor(CalciteUtils.toFieldType(SqlTypeName.VARCH= AR)) =20 Review comment: > **akedin** wrote: > I don't think that CalciteUtils should be used here, even if it's temp= orary. I'd rather have our own `SqlType.VARCHAR =3D TypeName.STRING.withMet= adata("VARCHAR")`. =20 Done. Added it to RowSqlTypes (so we can later remove the builder class = there, but leave the defined types. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 87701) Time Spent: 7h 20m (was: 7h 10m) > Support schema in PCollections > ------------------------------ > > Key: BEAM-3437 > URL: https://issues.apache.org/jira/browse/BEAM-3437 > Project: Beam > Issue Type: Wish > Components: beam-model > Reporter: Jean-Baptiste Onofr=C3=A9 > Assignee: Jean-Baptiste Onofr=C3=A9 > Priority: Major > Time Spent: 7h 20m > Remaining Estimate: 0h > > As discussed with some people in the team, it would be great to add schem= a support in {{PCollections}}. It will allow us: > 1. To expect some data type in {{PTransforms}} > 2. Improve some runners with additional features (I'm thinking about Spar= k runner with data frames for instance). > A technical draft document has been created:=20 > https://docs.google.com/document/d/1tnG2DPHZYbsomvihIpXruUmQ12pHGK0QIvXS1= FOTgRc/edit?disco=3DAAAABhykQIs&ts=3D5a203b46&usp=3Dcomment_email_document > I also started a PoC on a branch, I will update this Jira with a "discuss= ion" PR. -- This message was sent by Atlassian JIRA (v7.6.3#76005)