From commits-return-64551-archive-asf-public=cust-asf.ponee.io@beam.apache.org Wed Apr 4 01:03:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 5459118067C for ; Wed, 4 Apr 2018 01:03:04 +0200 (CEST) Received: (qmail 22260 invoked by uid 500); 3 Apr 2018 23:03:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 22228 invoked by uid 99); 3 Apr 2018 23:03:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 03 Apr 2018 23:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id D5D0D1823E2 for ; Tue, 3 Apr 2018 23:03:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id 26nX5C85wIFn for ; Tue, 3 Apr 2018 23:03:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 65EB35F283 for ; Tue, 3 Apr 2018 23:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 86FDFE021A for ; Tue, 3 Apr 2018 23:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 494E125607 for ; Tue, 3 Apr 2018 23:03:00 +0000 (UTC) Date: Tue, 3 Apr 2018 23:03:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-3257) Migrate Python Jenkins PreCommits to Gradle MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3257?focusedWorklogId=87325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87325 ] ASF GitHub Bot logged work on BEAM-3257: ---------------------------------------- Author: ASF GitHub Bot Created on: 03/Apr/18 23:02 Start Date: 03/Apr/18 23:02 Worklog Time Spent: 10m Work Description: udim commented on a change in pull request #5010: [BEAM-3257] Add Python precommit gradle config URL: https://github.com/apache/beam/pull/5010#discussion_r178985870 ########## File path: sdks/python/build.gradle ########## @@ -25,75 +25,123 @@ apply plugin: "base" task test {} check.dependsOn test -task setupTest { +def envdir = "${project.buildDir}/gradleenv" + +task setupVirtualenv { doLast { + exec { + commandLine 'virtualenv', "${envdir}" + } exec { executable 'sh' - args '-c', 'which tox || pip install --user --upgrade tox' + args '-c', "source ${envdir}/bin/activate && pip install --upgrade tox" } } + outputs.files("$buildDir/.gradleenv/bin/tox") } -task sdist { +task sdist (dependsOn: 'setupVirtualenv') { Review comment: done ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 87325) > Migrate Python Jenkins PreCommits to Gradle > ------------------------------------------- > > Key: BEAM-3257 > URL: https://issues.apache.org/jira/browse/BEAM-3257 > Project: Beam > Issue Type: Sub-task > Components: build-system, testing > Reporter: Luke Cwik > Assignee: Udi Meiri > Priority: Major > Time Spent: 2h > Remaining Estimate: 0h > > Code is here: https://github.com/apache/beam/blob/master/.test-infra/jenkins/job_beam_PreCommit_Python_MavenInstall.groovy -- This message was sent by Atlassian JIRA (v7.6.3#76005)