beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4053) Go should have a postcommit run on a cron schedule
Date Wed, 11 Apr 2018 21:14:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4053?focusedWorklogId=90169&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-90169
]

ASF GitHub Bot logged work on BEAM-4053:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/18 21:13
            Start Date: 11/Apr/18 21:13
    Worklog Time Spent: 10m 
      Work Description: aaltay closed pull request #5101: [BEAM-4053] Add a Go postcommit
URL: https://github.com/apache/beam/pull/5101
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.test-infra/jenkins/job_beam_PostCommit_Go_GradleBuild.groovy b/.test-infra/jenkins/job_beam_PostCommit_Go_GradleBuild.groovy
new file mode 100644
index 00000000000..0e667b4c109
--- /dev/null
+++ b/.test-infra/jenkins/job_beam_PostCommit_Go_GradleBuild.groovy
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import common_job_properties
+
+// This is the Go postcommit which runs a gradle build, and the current set
+// of postcommit tests.
+job('beam_PostCommit_Go_GradleBuild') {
+  description('Runs Go PostCommit tests against master.')
+
+  // Execute concurrent builds if necessary.
+  concurrentBuild()
+
+  // Set common parameters.
+  common_job_properties.setTopLevelMainJobProperties(
+    delegate,
+    'master',
+    150)
+
+  // Sets that this is a PostCommit job.
+  common_job_properties.setPostCommit(delegate, '15 */6 * * *', false)
+
+  def gradle_command_line = './gradlew ' + common_job_properties.gradle_switches.join(' ')
+ ' :goPostCommit'
+
+  // Allows triggering this build against pull requests.
+  common_job_properties.enablePhraseTriggeringFromPullRequest(
+      delegate,
+      gradle_command_line,
+      'Run Go PostCommit')
+
+  steps {
+    gradle {
+      rootBuildScriptDir(common_job_properties.checkoutDir)
+      tasks(':goPostCommit')
+      common_job_properties.setGradleSwitches(delegate)
+    }
+  }
+}
diff --git a/build.gradle b/build.gradle
index 102fffbe687..128ac26e686 100644
--- a/build.gradle
+++ b/build.gradle
@@ -132,6 +132,11 @@ task goPreCommit() {
   dependsOn ":beam-sdks-go:test"
 }
 
+task goPostCommit() {
+  // Same currently as precommit, but duplicated to provide a clearer signal of reliability.
+  dependsOn ":goPreCommit"
+}
+
 task pythonPreCommit() {
   dependsOn ":rat"
   dependsOn ":beam-sdks-python:check"


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 90169)
    Time Spent: 1h 40m  (was: 1.5h)

> Go should have a postcommit run on a cron schedule
> --------------------------------------------------
>
>                 Key: BEAM-4053
>                 URL: https://issues.apache.org/jira/browse/BEAM-4053
>             Project: Beam
>          Issue Type: New Feature
>          Components: build-system
>            Reporter: Alan Myrvold
>            Assignee: Alan Myrvold
>            Priority: Major
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> To allow assessing if it is reliable, there should be a Go postcommit, initially the
same as the precommit.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message